Revert #13076 "Adds validation to throw MSB4259 when property references contain leading or trailing whitespace outside of conditions.#13184
Merged
JanProvaznik merged 1 commit intodotnet:mainfrom Feb 3, 2026
Conversation
…tain leading or trailing whitespace outside of conditions. (dotnet#13076)" This reverts commit fa41623.
YuliiaKovalova
approved these changes
Feb 3, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Feb 3, 2026
…ces contain leading or trailing whitespace outside of conditions. (#13184)
YuliiaKovalova
pushed a commit
that referenced
this pull request
Feb 5, 2026
Defense in depth for problems like the one that led to #13184 which led to broken VS Canary users.
JanProvaznik
added a commit
to JanProvaznik/msbuild
that referenced
this pull request
Feb 25, 2026
…eferences contain leading or trailing whitespace outside of conditions. (dotnet#13184)
JanProvaznik
pushed a commit
to JanProvaznik/msbuild
that referenced
this pull request
Feb 25, 2026
Defense in depth for problems like the one that led to dotnet#13184 which led to broken VS Canary users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fa41623.
Fixes #
internally reported regression
Context
Changes Made
Testing
Notes
@huulinhnguyen-dev
error is too heavy handed, in the property function case it's a regression and in the property case it should be either a warning or buildcheck