Merged
Conversation
It looks like the Setup engine treats all ngened files as DLLs by default, so `MSBuild.exe` was getting ngened in `vsn.exe` context, which doesn't make a lot of sense. Explicitly tell the engine to ngen it in its own context.
Member
Author
|
Test insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/599734 Before (ngen64 log): After: |
YuliiaKovalova
approved these changes
Jan 16, 2025
JanProvaznik
added a commit
to JanProvaznik/msbuild
that referenced
this pull request
Jan 29, 2025
This reverts commit 6bed355.
JanProvaznik
added a commit
that referenced
this pull request
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the Setup engine treats all ngened files as DLLs by default, so
MSBuild.exewas getting ngened invsn.execontext, which doesn't make a lot of sense. Explicitly tell the engine to ngen it in its own context.Notes to January self: look at ngen logs in VS perf tests. Verify
vsn.execontext