Revert "Specify ngen configs for exes (#11182)"#11351
Merged
JanProvaznik merged 1 commit intodotnet:mainfrom Jan 30, 2025
Merged
Revert "Specify ngen configs for exes (#11182)"#11351JanProvaznik merged 1 commit intodotnet:mainfrom
JanProvaznik merged 1 commit intodotnet:mainfrom
Conversation
This reverts commit 6bed355.
Contributor
|
Hello @JanProvaznik, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
SimaTian
approved these changes
Jan 29, 2025
JanKrivanek
approved these changes
Jan 30, 2025
Member
|
Please open an item so thart the underlying problem gets investigated amd proper ngnening ensured |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6bed355.
Context
#11182 likely caused images loaded regression in VS insertion https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/606630
Changes Made
Testing
experimental insertion perf passed
https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/606667
Notes