Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a change to the Helix build configuration that modified the condition for setting the Creator property. The original change set Creator based on whether it was empty, but this revision changes the condition to check if HelixAccessToken is empty instead.
Key Change:
- Modified the condition for setting the Creator property in Helix configuration from checking
$(Creator)to checking$(HelixAccessToken)
| <HelixBuild Condition="'$(HelixBuild)' == ''">default</HelixBuild> | ||
| <HelixTargetQueues>Windows.10.Amd64.Open;osx.15.arm64.maui.open</HelixTargetQueues> | ||
| <Creator Condition="'$(Creator)' == ''">maui</Creator> | ||
| <Creator Condition="'$(HelixAccessToken)' == ''">maui</Creator> |
There was a problem hiding this comment.
The condition logic appears inverted. Setting Creator='maui' when HelixAccessToken is empty may cause authentication issues. Typically, Creator should be set when an access token IS provided (authenticated scenarios), not when it's missing (anonymous scenarios). Consider changing the condition to Condition="'$(HelixAccessToken)' != ''" or verify this is the intended behavior.
Suggested change
| <Creator Condition="'$(HelixAccessToken)' == ''">maui</Creator> | |
| <Creator Condition="'$(HelixAccessToken)' != ''">maui</Creator> |
Member
Author
|
/backport to release/10.0.1xx-sr1 |
Contributor
|
Started backporting to |
rmarinho
added a commit
that referenced
this pull request
Nov 21, 2025
evgenygunko
pushed a commit
to evgenygunko/CopyWordsDA
that referenced
this pull request
Nov 26, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Microsoft.Maui.Controls](https://github.com/dotnet/maui) | nuget | patch | `10.0.10` -> `10.0.11` | --- ### Release Notes <details> <summary>dotnet/maui (Microsoft.Maui.Controls)</summary> ### [`v10.0.11`](https://github.com/dotnet/maui/releases/tag/10.0.11): SR1.1 [Compare Source](dotnet/maui@10.0.10...10.0.11) ##### What's Changed .NET MAUI 10.0.11 introduces significant improvements across all platforms with focus on quality, performance, and developer experience. This release includes 11 commits with various improvements, bug fixes, and enhancements. ##### .NET MAUI Product Fixes ##### Android - Fix content page title clipping on Android API < 30 with window insets compatibility by [@​Copilot](https://github.com/Copilot) in dotnet/maui#32738 <details> <summary>🔧 Fixes</summary> - [Shell content page title position incorrect/clipped](dotnet/maui#32526) </details> ##### Button - \[release/10.0.1xx-sr1] Removed Value property coercion in RadioButton by [@​github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#32604 <details> <summary>🔧 Fixes</summary> - [Removed Value property coercion in RadioButton](dotnet/maui#32489) </details> ##### DateTimePicker - Fix crash when TimePicker.Time is set to null (backport from PR [#​32660](dotnet/maui#32660)) by [@​Copilot](https://github.com/Copilot) in dotnet/maui#32715 <details> <summary>🔧 Fixes</summary> - [Fix crash when TimePicker.Time is set to null](dotnet/maui#32660) </details> ##### Gestures - \[release/10.0.1xx-sr1] predictive back gesture support for Android 13+ by [@​github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#32635 <details> <summary>🔧 Fixes</summary> - [predictive back gesture support for Android 13+](dotnet/maui#32461) </details> ##### Infrastructure - \[release/10.0.1xx-sr1] \[ci] Revert changes setting Creator by [@​github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#32803 <details> <summary>🔧 Fixes</summary> - [\[ci\] Revert changes setting Creator](dotnet/maui#32743) </details> ##### Mediapicker - \[release/10.0.1xx-sr1] \[Android] Refactor selection limit handling in MediaPicker by [@​github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#32628 <details> <summary>🔧 Fixes</summary> - [\[Android\] Refactor selection limit handling in MediaPicker](dotnet/maui#32571) ...
This was referenced Dec 1, 2025
7 tasks
This was referenced Dec 18, 2025
Merged
Merged
This was referenced Dec 18, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Revert as this seems not needed