Fix crash when TimePicker.Time is set to null by breyed · Pull Request #32660 · dotnet/maui

breyed · 2025-11-17T00:24:01Z

Description of Change

Since TimePicker now supports nullable, the casts need to be nullable to match the TimeChangedEventArgs properties.

Issues Fixed

timeSpan.Time = null throws a NullReferenceException. (This PR is also the reporting issue.)

dotnet-policy-service · 2025-11-17T00:27:46Z

Hey there @@breyed! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot

Pull Request Overview

This PR fixes a crash that occurs when setting TimePicker.Time to null by updating the type casts to nullable TimeSpan in the TimePropertyChanged event handler.

Key Changes:

Modified the casts in TimePropertyChanged from (TimeSpan) to (TimeSpan?) to properly handle nullable TimeSpan values

jfversluis · 2025-11-18T10:05:27Z

/azp run MAUI-public

azure-pipelines · 2025-11-18T10:05:41Z

Azure Pipelines successfully started running 1 pipeline(s).

jfversluis · 2025-11-18T11:31:15Z

/rebase

azure-pipelines · 2025-11-18T12:58:51Z

Azure Pipelines successfully started running 1 pipeline(s).

jfversluis · 2025-11-18T15:44:51Z

Awesome @breyed sorry we missed this! Thank you for contributing!

jfversluis · 2025-11-18T15:45:49Z

/rebase

Since TimePicker now supports nullable, the casts need to be nullable to match the TimeChangedEventArgs properties. Otherwise, `timeSpan.Time = null` throws a NullReferenceException.

PureWeen · 2025-11-18T20:14:39Z

/backport to release/10.0.1xx-sr1

github-actions · 2025-11-18T20:16:04Z

Started backporting to release/10.0.1xx-sr1 (link to workflow run)

github-actions · 2025-11-18T20:16:34Z

@PureWeen backporting to release/10.0.1xx-sr1 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

… (#32715) * Initial plan * Fix crash when TimePicker.Time is set to null (backport from PR #32660) Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Microsoft.Maui.Controls](https://github.com/dotnet/maui) | nuget | patch | `10.0.10` -> `10.0.11` | --- ### Release Notes <details> <summary>dotnet/maui (Microsoft.Maui.Controls)</summary> ### [`v10.0.11`](https://github.com/dotnet/maui/releases/tag/10.0.11): SR1.1 [Compare Source](dotnet/maui@10.0.10...10.0.11) ##### What's Changed .NET MAUI 10.0.11 introduces significant improvements across all platforms with focus on quality, performance, and developer experience. This release includes 11 commits with various improvements, bug fixes, and enhancements. ##### .NET MAUI Product Fixes ##### Android - Fix content page title clipping on Android API < 30 with window insets compatibility by [@Copilot](https://github.com/Copilot) in dotnet/maui#32738 <details> <summary>🔧 Fixes</summary> - [Shell content page title position incorrect/clipped](dotnet/maui#32526) </details> ##### Button - \[release/10.0.1xx-sr1] Removed Value property coercion in RadioButton by [@github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#32604 <details> <summary>🔧 Fixes</summary> - [Removed Value property coercion in RadioButton](dotnet/maui#32489) </details> ##### DateTimePicker - Fix crash when TimePicker.Time is set to null (backport from PR [#32660](dotnet/maui#32660)) by [@Copilot](https://github.com/Copilot) in dotnet/maui#32715 <details> <summary>🔧 Fixes</summary> - [Fix crash when TimePicker.Time is set to null](dotnet/maui#32660) </details> ##### Gestures - \[release/10.0.1xx-sr1] predictive back gesture support for Android 13+ by [@github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#32635 <details> <summary>🔧 Fixes</summary> - [predictive back gesture support for Android 13+](dotnet/maui#32461) </details> ##### Infrastructure - \[release/10.0.1xx-sr1] \[ci] Revert changes setting Creator by [@github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#32803 <details> <summary>🔧 Fixes</summary> - [\[ci\] Revert changes setting Creator](dotnet/maui#32743) </details> ##### Mediapicker - \[release/10.0.1xx-sr1] \[Android] Refactor selection limit handling in MediaPicker by [@github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#32628 <details> <summary>🔧 Fixes</summary> - [\[Android\] Refactor selection limit handling in MediaPicker](dotnet/maui#32571) ...

Copilot AI review requested due to automatic review settings November 17, 2025 00:24

Copilot started reviewing on behalf of breyed November 17, 2025 00:24 View session

Copilot finished reviewing on behalf of breyed November 17, 2025 00:26

dotnet-policy-service bot added the community ✨ Community Contribution label Nov 17, 2025

Copilot AI reviewed Nov 17, 2025

View reviewed changes

github-actions bot force-pushed the patch-1 branch from 7915343 to d0f9064 Compare November 18, 2025 11:32

jfversluis approved these changes Nov 18, 2025

View reviewed changes

jfversluis changed the base branch from main to inflight/current November 18, 2025 15:45

github-actions bot force-pushed the patch-1 branch from d0f9064 to d40e133 Compare November 18, 2025 15:47

Change TimeSelected event to handle nullable TimeSpan

75d9dd5

Since TimePicker now supports nullable, the casts need to be nullable to match the TimeChangedEventArgs properties. Otherwise, `timeSpan.Time = null` throws a NullReferenceException.

jfversluis force-pushed the patch-1 branch from d40e133 to 75d9dd5 Compare November 18, 2025 15:56

jfversluis merged commit 55ec5ec into dotnet:inflight/current Nov 18, 2025
1 check passed

Copilot AI mentioned this pull request Nov 18, 2025

Fix crash when TimePicker.Time is set to null (backport from PR #32660) #32715

Merged

Copilot AI added a commit that referenced this pull request Nov 18, 2025

Fix crash when TimePicker.Time is set to null (backport from PR #32660)

c3d0cb4

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

kubaflo mentioned this pull request Nov 18, 2025

[Issue-Resolver] Fix #32709 - TimePicker crashes with null Time and TimeSelected event #32720

Closed

dependabot bot mentioned this pull request Nov 25, 2025

Bump Microsoft.Maui.Controls.Maps from 10.0.10 to 10.0.11 ehtick/Maui#449

Closed

This was referenced Dec 1, 2025

Bump Microsoft.Maui.Graphics from 9.0.120 to 10.0.11 DCS-BR-Tools/briefing-room-for-dcs#1193

Closed

Bump Microsoft.Maui.Graphics from 8.0.100 to 10.0.11 IvyCafe/Medicolor#28

Closed

dependabot bot mentioned this pull request Dec 8, 2025

Bump Microsoft.Maui.Graphics from 8.0.100 to 10.0.11 IvyCafe/Medicolor#30

Closed

7 tasks

github-actions bot locked and limited conversation to collaborators Dec 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix crash when TimePicker.Time is set to null#32660

Fix crash when TimePicker.Time is set to null#32660
jfversluis merged 1 commit intodotnet:inflight/currentfrom
breyed:patch-1

breyed commented Nov 17, 2025 •

edited by PureWeen

Loading

Uh oh!

dotnet-policy-service bot commented Nov 17, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

jfversluis commented Nov 18, 2025 •

edited

Loading

Uh oh!

azure-pipelines bot commented Nov 18, 2025

Uh oh!

jfversluis commented Nov 18, 2025

Uh oh!

azure-pipelines bot commented Nov 18, 2025

Uh oh!

jfversluis commented Nov 18, 2025

Uh oh!

jfversluis commented Nov 18, 2025

Uh oh!

Uh oh!

PureWeen commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

breyed commented Nov 17, 2025 • edited by PureWeen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Issues Fixed

Uh oh!

dotnet-policy-service bot commented Nov 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

jfversluis commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Nov 18, 2025

Uh oh!

jfversluis commented Nov 18, 2025

Uh oh!

azure-pipelines bot commented Nov 18, 2025

Uh oh!

jfversluis commented Nov 18, 2025

Uh oh!

jfversluis commented Nov 18, 2025

Uh oh!

Uh oh!

PureWeen commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

breyed commented Nov 17, 2025 •

edited by PureWeen

Loading

jfversluis commented Nov 18, 2025 •

edited

Loading