Expose DispatcherExtensions so it could be used outside of Maui as well by Vignesh-SF3580 · Pull Request #30488 · dotnet/maui

Vignesh-SF3580 · 2025-07-08T12:46:55Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Exposing the DispatcherExtensions so it could be used outside of Maui as well.

Issues Fixed

Fixes #29258

jsuarezruiz · 2025-07-08T14:51:40Z

/azp run

azure-pipelines · 2025-07-08T14:52:08Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull Request Overview

This PR exposes new DispatcherExtensions methods so they can be used outside of .NET MAUI and updates the Public API accordingly.

Adds DispatchIfRequired and multiple DispatchIfRequiredAsync overloads to DispatcherExtensions
Updates unit tests to cover all new extension overloads
Removes duplicate dispatcher helpers in Controls and adds necessary using directives

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/Core/src/Dispatching/DispatcherExtensions.cs	Added new `DispatchIfRequired` and various `DispatchIfRequiredAsync` extension methods
src/Core/tests/UnitTests/Dispatching/DispatcherTests.cs	Added 14 new facts to verify each overload of the new extension methods
src/Core/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt	Registered the new extension methods in the Public API
src/Core/src/PublicAPI/netstandard/PublicAPI.Unshipped.txt	Registered the new extension methods in the Public API
src/Core/src/PublicAPI/net/PublicAPI.Unshipped.txt	Registered the new extension methods in the Public API
src/Core/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt	Registered the new extension methods in the Public API
src/Core/src/PublicAPI/net-tizen/PublicAPI.Unshipped.txt	Registered the new extension methods in the Public API
src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt	Registered the new extension methods in the Public API
src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt	Registered the new extension methods in the Public API
src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt	Registered the new extension methods in the Public API
src/Controls/src/Core/Handlers/Items/Android/ItemsSources/ObservableItemsSource.cs	Added `using Microsoft.Maui.Dispatching;` to use shared dispatcher extensions
src/Controls/src/Core/Handlers/Items/Android/ItemsSources/ObservableGroupedSource.cs	Added `using Microsoft.Maui.Dispatching;` to use shared dispatcher extensions
src/Controls/src/Core/DispatcherExtensions.cs	Removed local `DispatchIfRequired*` implementations in favor of the shared ones in Core
src/Controls/src/Core/BindingExpression.cs	Added `using Microsoft.Maui.Dispatching;`
src/Controls/src/Core/AppThemeBinding.cs	Added `using Microsoft.Maui.Dispatching;`

Comments suppressed due to low confidence (4)

src/Core/src/Dispatching/DispatcherExtensions.cs:97

New public extension methods require corresponding updates to the official documentation (under /docs) to describe DispatchIfRequired and its overloads.

		public static void DispatchIfRequired(this IDispatcher dispatcher, Action action)

src/Core/src/Dispatching/DispatcherExtensions.cs:112

Fill in the <param> and <returns> XML comments for the DispatchIfRequiredAsync overloads to clearly document parameters and return values.

		/// <param name="dispatcher"></param>

src/Controls/src/Core/BindingExpression.cs:13

[nitpick] This using directive appears unused in this file; consider removing it to keep imports clean.

using Microsoft.Maui.Dispatching;

src/Controls/src/Core/AppThemeBinding.cs:6

[nitpick] This using directive appears unused in this file; consider removing it to keep imports clean.

using Microsoft.Maui.Dispatching;

jsuarezruiz

There are some build errors:

C:\a\_work\1\s\src\Controls\src\Core\Platform\Windows\CollectionView\GroupedItemTemplateCollection.cs(83,26): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-windows10.0.19041.0]
C:\a\_work\1\s\src\Controls\src\Core\Platform\Windows\CollectionView\ObservableItemTemplateCollection.cs(146,26): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-windows10.0.19041.0]
C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.7.250606001\buildTransitive\Microsoft.UI.Xaml.Markup.Compiler.interop.targets(845,9): error MSB3073: The command ""C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.7.250606001\buildTransitive\..\tools\net6.0\..\net472\XamlCompiler.exe" "C:\a\_work\1\s\artifacts\obj\Controls.Core\Release\net10.0-windows10.0.19041.0\\input.json" "C:\a\_work\1\s\artifacts\obj\Controls.Core\Release\net10.0-windows10.0.19041.0\\output.json"" exited with code 1. [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-windows10.0.19041.0]
C:\a\_work\1\s\src\Compatibility\Core\src\iOS\VisualElementTracker.cs(347,21): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Compatibility\Core\src\Compatibility.csproj::TargetFramework=net10.0-ios18.5]
C:\a\_work\1\s\src\Compatibility\Core\src\iOS\VisualElementTracker.cs(347,21): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Compatibility\Core\src\Compatibility.csproj::TargetFramework=net10.0-maccatalyst18.5]
C:\a\_work\1\s\src\Controls\src\Core\Platform\Windows\CollectionView\ObservableItemTemplateCollection.cs(146,26): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-windows10.0.20348.0]
C:\a\_work\1\s\src\Controls\src\Core\Platform\Windows\CollectionView\GroupedItemTemplateCollection.cs(83,26): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-windows10.0.20348.0]
C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.7.250606001\buildTransitive\Microsoft.UI.Xaml.Markup.Compiler.interop.targets(845,9): error MSB3073: The command ""C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.7.250606001\buildTransitive\..\tools\net6.0\..\net472\XamlCompiler.exe" "C:\a\_work\1\s\artifacts\obj\Controls.Core\Release\net10.0-windows10.0.20348.0\\input.json" "C:\a\_work\1\s\artifacts\obj\Controls.Core\Release\net10.0-windows10.0.20348.0\\output.json"" exited with code 1. [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-windows10.0.20348.0]
C:\a\_work\1\s\src\Compatibility\Core\src\Android\CollectionView\ObservableGroupedSource.cs(235,35): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Compatibility\Core\src\Compatibility.csproj::TargetFramework=net10.0-android36.0]
C:\a\_work\1\s\src\Compatibility\Core\src\Android\CollectionView\ObservableItemsSource.cs(94,26): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Compatibility\Core\src\Compatibility.csproj::TargetFramework=net10.0-android36.0]
    10 Error(s)

Could you review it?

Vignesh-SF3580 · 2025-07-09T08:19:31Z

There are some build errors:

C:\a\_work\1\s\src\Controls\src\Core\Platform\Windows\CollectionView\GroupedItemTemplateCollection.cs(83,26): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-windows10.0.19041.0]
C:\a\_work\1\s\src\Controls\src\Core\Platform\Windows\CollectionView\ObservableItemTemplateCollection.cs(146,26): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-windows10.0.19041.0]
C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.7.250606001\buildTransitive\Microsoft.UI.Xaml.Markup.Compiler.interop.targets(845,9): error MSB3073: The command ""C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.7.250606001\buildTransitive\..\tools\net6.0\..\net472\XamlCompiler.exe" "C:\a\_work\1\s\artifacts\obj\Controls.Core\Release\net10.0-windows10.0.19041.0\\input.json" "C:\a\_work\1\s\artifacts\obj\Controls.Core\Release\net10.0-windows10.0.19041.0\\output.json"" exited with code 1. [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-windows10.0.19041.0]
C:\a\_work\1\s\src\Compatibility\Core\src\iOS\VisualElementTracker.cs(347,21): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Compatibility\Core\src\Compatibility.csproj::TargetFramework=net10.0-ios18.5]
C:\a\_work\1\s\src\Compatibility\Core\src\iOS\VisualElementTracker.cs(347,21): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Compatibility\Core\src\Compatibility.csproj::TargetFramework=net10.0-maccatalyst18.5]
C:\a\_work\1\s\src\Controls\src\Core\Platform\Windows\CollectionView\ObservableItemTemplateCollection.cs(146,26): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-windows10.0.20348.0]
C:\a\_work\1\s\src\Controls\src\Core\Platform\Windows\CollectionView\GroupedItemTemplateCollection.cs(83,26): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-windows10.0.20348.0]
C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.7.250606001\buildTransitive\Microsoft.UI.Xaml.Markup.Compiler.interop.targets(845,9): error MSB3073: The command ""C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.7.250606001\buildTransitive\..\tools\net6.0\..\net472\XamlCompiler.exe" "C:\a\_work\1\s\artifacts\obj\Controls.Core\Release\net10.0-windows10.0.20348.0\\input.json" "C:\a\_work\1\s\artifacts\obj\Controls.Core\Release\net10.0-windows10.0.20348.0\\output.json"" exited with code 1. [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-windows10.0.20348.0]
C:\a\_work\1\s\src\Compatibility\Core\src\Android\CollectionView\ObservableGroupedSource.cs(235,35): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Compatibility\Core\src\Compatibility.csproj::TargetFramework=net10.0-android36.0]
C:\a\_work\1\s\src\Compatibility\Core\src\Android\CollectionView\ObservableItemsSource.cs(94,26): error CS1061: 'IDispatcher' does not contain a definition for 'DispatchIfRequired' and no accessible extension method 'DispatchIfRequired' accepting a first argument of type 'IDispatcher' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Compatibility\Core\src\Compatibility.csproj::TargetFramework=net10.0-android36.0]
    10 Error(s)

Could you review it?

@jsuarezruiz I’ve resolved the build errors. Please let me know if any further changes are required.

PureWeen · 2025-07-10T05:55:35Z

/azp run

azure-pipelines · 2025-07-10T05:55:56Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen

tests are failing

Vignesh-SF3580 · 2025-07-16T14:00:34Z

tests are failing

@PureWeen There are no device test failures in the CI. The UI test failures are already addressed in this PR. The PR has been rebased, and the tests should pass in the next CI run.

PureWeen

rebase to fix published

Vignesh-SF3580 · 2025-07-17T10:48:55Z

rebase to fix published

@PureWeen Rebased the branch and resolved the conflicts.

PureWeen · 2025-07-17T18:34:50Z

/azp run

azure-pipelines · 2025-07-17T18:35:13Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen

RADLE : warning : We recommend using a newer Android Gradle plugin to use compileSdk = 34 [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]
/mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(201,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequired(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Action! action) -> void' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]
/mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(202,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Action! action) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]
/mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(203,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Func<System.Threading.Tasks.Task!>! action) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]
/mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(204,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Func! func) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]
/mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(205,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Func<System.Threading.Tasks.Task!>! funcTask) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]

Build FAILED.

GRADLE : warning : We recommend using a newer Android Gradle plugin to use compileSdk = 34 [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]
/mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(201,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequired(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Action! action) -> void' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]
/mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(202,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Action! action) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]
/mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(203,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Func<System.Threading.Tasks.Task!>! action) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]
/mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(204,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Func! func) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]
/mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(205,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Func<System.Threading.Tasks.Task!>! funcTask) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]
1 Warning(s)
5 Error(s)

Vignesh-SF3580 · 2025-07-21T06:18:53Z

RADLE : warning : We recommend using a newer Android Gradle plugin to use compileSdk = 34 [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0] /mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(201,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequired(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Action! action) -> void' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0] /mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(202,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Action! action) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0] /mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(203,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Func<System.Threading.Tasks.Task!>! action) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0] /mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(204,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Func! func) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0] /mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(205,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Func<System.Threading.Tasks.Task!>! funcTask) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0]

Build FAILED.

GRADLE : warning : We recommend using a newer Android Gradle plugin to use compileSdk = 34 [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0] /mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(201,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequired(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Action! action) -> void' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0] /mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(202,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Action! action) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0] /mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(203,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Func<System.Threading.Tasks.Task!>! action) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0] /mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(204,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Func! func) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0] /mnt/vss/_work/1/s/src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt(205,1): error RS0025: The symbol 'static Microsoft.Maui.Dispatching.DispatcherExtensions.DispatchIfRequiredAsync(this Microsoft.Maui.Dispatching.IDispatcher! dispatcher, System.Func<System.Threading.Tasks.Task!>! funcTask) -> System.Threading.Tasks.Task!' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/mnt/vss/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net10.0-android36.0] 1 Warning(s) 5 Error(s)

@PureWeen I have resolved the build errors and conflicts.

PureWeen · 2025-07-22T18:23:01Z

/azp run

azure-pipelines · 2025-07-22T18:23:23Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen

tests failing

Vignesh-SF3580 · 2025-07-23T11:12:20Z

tests failing

@PureWeen The failed UI and device tests are passing locally.

mattleibow · 2025-07-24T21:33:10Z

src/Core/src/Dispatching/DispatcherExtensions.cs

+			if (dispatcher is null)
+			{
+				var currentThreadDispatcher = Dispatcher.GetForCurrentThread();
+				if (currentThreadDispatcher?.IsDispatchRequired == true)
+				{
+					currentThreadDispatcher.Dispatch(action);
+					return;
+				}
+			}


What is the reason for this additional bit of code? If dispatcher is null, then it probably should throw. You are asking it to run on the specified dispatcher, and it may give random results if there is no dispatcher.

@mattleibow When the dispatcher is null, the method currently executes the action directly, which may not align with expectations in certain scenarios—such as in the PropertyChangeBindingsOccurThroughMainThread test, where InvokeOnMainThread is expected to be called when isOnBackgroundThread is true.
To address this, the additional logic uses Dispatcher.GetForCurrentThread() as a fallback to ensure the action is dispatched appropriately. This approach helps maintain thread-safety and ensures consistent behavior even when an explicit dispatcher reference is not available. It also allows mock dispatchers in test environments to be respected, avoiding unintended test failures or bypassed execution paths.
This change preserves expected behavior without altering the existing public contract and provides a safer fallback in cases where the dispatcher is not explicitly passed. Please let me know if you have any suggestions.

I think is fine is just an extra check, it will not throw and fallback to the previous way of just calling the action() if IsDispatchRequired on the new found dispatcher is false.

…ui as well" (#31184) Reverts #30488 Fixes #31139

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jul 8, 2025

This was referenced Jul 8, 2025

Expose DispatcherExtensions so it could be used outside of Maui as well #29259

Closed

Make DispatcherExtensions with DispatchIfRequired() and FindDispatcher() publicly available #30424

Closed

PureWeen added this to the .NET 10.0-preview7 milestone Jul 8, 2025

PureWeen added this to MAUI SDK Ongoing Jul 8, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Jul 8, 2025

Vignesh-SF3580 marked this pull request as ready for review July 9, 2025 05:03

Copilot AI review requested due to automatic review settings July 9, 2025 05:03

Vignesh-SF3580 requested a review from a team as a code owner July 9, 2025 05:03

Vignesh-SF3580 requested review from jsuarezruiz and rmarinho July 9, 2025 05:03

Copilot AI reviewed Jul 9, 2025

View reviewed changes

jsuarezruiz suggested changes Jul 9, 2025

View reviewed changes

github-project-automation bot moved this from Todo to Changes Requested in MAUI SDK Ongoing Jul 9, 2025

PureWeen requested changes Jul 15, 2025

View reviewed changes

Vignesh-SF3580 force-pushed the issue-29258 branch from 02435a8 to 2af8944 Compare July 16, 2025 13:53

PureWeen requested changes Jul 17, 2025

View reviewed changes

Vignesh-SF3580 force-pushed the issue-29258 branch from 2af8944 to b5856bc Compare July 17, 2025 06:59

PureWeen added the p/0 Current heighest priority issues that we are targeting for a release. label Jul 17, 2025

PureWeen moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Jul 17, 2025

PureWeen requested changes Jul 17, 2025

View reviewed changes

github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing Jul 17, 2025

Vignesh-SF3580 added 5 commits July 21, 2025 10:24

updated code changes

fde3d33

Added UnitTest

66c9bf4

added testcases

222dc98

resolved build errors.

aa119d2

Update PublicAPI.Unshipped.txt

bb5571d

Vignesh-SF3580 force-pushed the issue-29258 branch from 6872307 to bb5571d Compare July 21, 2025 04:55

PureWeen requested changes Jul 23, 2025

View reviewed changes

Update DispatcherExtensions.cs

9a47966

mattleibow reviewed Jul 24, 2025

View reviewed changes

rmarinho approved these changes Jul 25, 2025

View reviewed changes

dotnet deleted a comment from azure-pipelines bot Jul 25, 2025

dotnet deleted a comment from PureWeen Jul 25, 2025

rmarinho moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Jul 25, 2025

rmarinho merged commit b18db8b into dotnet:net10.0 Jul 28, 2025
132 checks passed

github-project-automation bot moved this from Ready To Review to Done in MAUI SDK Ongoing Jul 28, 2025

PureWeen mentioned this pull request Aug 14, 2025

[net10.0] MAUI no longer marshalls bindable updates to the UI thread #31139

Closed

jfversluis mentioned this pull request Aug 15, 2025

Revert "Expose DispatcherExtensions so it could be used outside of Maui as well" #31184

Merged

jfversluis added a commit that referenced this pull request Aug 15, 2025

Revert "Expose DispatcherExtensions so it could be used outside of Ma…

93923d7

…ui as well" (#31184) Reverts #30488 Fixes #31139

PureWeen added the area-core label Aug 21, 2025

github-actions bot locked and limited conversation to collaborators Sep 21, 2025

Conversation

Vignesh-SF3580 commented Jul 8, 2025

Description of Change

Issues Fixed

Uh oh!

jsuarezruiz commented Jul 8, 2025

Uh oh!

azure-pipelines bot commented Jul 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

Vignesh-SF3580 commented Jul 9, 2025

Uh oh!

PureWeen commented Jul 10, 2025

Uh oh!

azure-pipelines bot commented Jul 10, 2025

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

Vignesh-SF3580 commented Jul 16, 2025

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

Vignesh-SF3580 commented Jul 17, 2025

Uh oh!

PureWeen commented Jul 17, 2025

Uh oh!

azure-pipelines bot commented Jul 17, 2025

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

Vignesh-SF3580 commented Jul 21, 2025

Uh oh!

PureWeen commented Jul 22, 2025

Uh oh!

azure-pipelines bot commented Jul 22, 2025

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

Vignesh-SF3580 commented Jul 23, 2025

Uh oh!

mattleibow Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Vignesh-SF3580 Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

rmarinho Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants