Revert "Expose DispatcherExtensions so it could be used outside of Maui as well"#31184
Merged
jfversluis merged 8 commits intonet10.0from Aug 15, 2025
Merged
Revert "Expose DispatcherExtensions so it could be used outside of Maui as well"#31184jfversluis merged 8 commits intonet10.0from
jfversluis merged 8 commits intonet10.0from
Conversation
…ui as we…" This reverts commit b18db8b.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This is a revert commit that undoes the previous changes made in PR #30488, which exposed DispatcherExtensions for use outside of MAUI. The revert addresses issue #31139 by removing the public API exposure and moving the extension methods back to the Controls project.
- Removes public
DispatcherExtensionsmethods from the Core project's public API - Removes comprehensive unit tests for the reverted extension methods
- Moves some dispatcher extension methods back to the Controls project with internal scope
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Core/tests/UnitTests/Dispatching/DispatcherTests.cs | Removes NSubstitute dependency and all unit tests for DispatcherExtensions methods |
| src/Core/src/PublicAPI/net-tizen/PublicAPI.Unshipped.txt | Removes public API entries for DispatcherExtensions methods |
| src/Core/src/Dispatching/DispatcherExtensions.cs | Removes all DispatchIfRequired extension method implementations |
| src/Controls/src/Core/DispatcherExtensions.cs | Adds back limited DispatchIfRequired methods with internal scope |
| Multiple platform files | Removes unused Microsoft.Maui.Dispatching imports |
| : funcTask(); | ||
| } | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
This revert removes public DispatcherExtensions methods that were previously available in the public API. This represents a breaking change that should not be included in minor versions or service releases.
PureWeen
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #30488
Fixes #31139