[Android] - Fix inconsistent footer scrolling when EmptyView is a string in CollectionView by prakashKannanSf3972 · Pull Request #29381 · dotnet/maui

prakashKannanSf3972 · 2025-05-07T15:04:48Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause

When the EmptyView is defined as a string, it occupies the entire parent space without considering header and footer dimensions, causing overlaps or forcing the footer into a scrollable area.

Description of Change

Enhanced layout logic to account for Header and Footer measurements when the EmptyView is specified as a string. This ensures the EmptyView no longer occupies the entire available space indiscriminately and allows the Footer to remain properly anchored, preserving the correct layout.
Enhanced UpdateHeaderFooterHeight to handle string-based content by creating a Label for measurement, ensuring accurate height calculations for header and footer items.

Issues Fixed

Fixes #28765

Tested the behaviour in the following platforms

Android
Windows
iOS
Mac

Output

Before	After
BeforeFix_Scrolling.mov	AftetFix_Fit.mov

jsuarezruiz · 2025-05-08T06:02:39Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-08T06:02:51Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

This PR fixes the footer scrolling issue on Android when an EmptyView is provided as a string by adjusting the layout logic to account for header and footer measurements.

Updated test cases to verify both string and view-based headers/footers.
Modified SimpleViewHolder.FromText to support dynamic width and height measurement.
Enhanced the EmptyViewAdapter to measure string-based EmptyViews correctly by using a Label for accurate size calculations.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28765.cs	Added test cases for different Header/Footer setups.
src/Controls/tests/TestCases.HostApp/Issues/Issue28765.cs	Updated the host app to include scenarios for string-based headers/footers.
src/Controls/src/Core/Handlers/Items/Android/SimpleViewHolder.cs	Modified the FromText method signature to include width/height delegates and improved EmptyView layout handling.
src/Controls/src/Core/Handlers/Items/Android/Adapters/EmptyViewAdapter.cs	Adjusted view holder creation and header/footer measurement to support string-based EmptyViews.

Copilot · 2025-05-08T13:04:54Z

src/Controls/src/Core/Handlers/Items/Android/SimpleViewHolder.cs

@@ -27,19 +27,19 @@ public void Recycle(ItemsView itemsView)
 			itemsView.RemoveLogicalChild(View);
 		}



[nitpick] The new parameters (width, height, and container) increase the method signature complexity. Consider adding inline documentation to clearly explain the purpose and expected usage of these parameters.

Suggested change

/// <summary>

/// Creates a SimpleViewHolder containing a text-based view.

/// </summary>

/// <param name="text">The text to display in the view.</param>

/// <param name="context">The Android context used to create the view.</param>

/// <param name="width">An optional function to calculate the width of the view.</param>

/// <param name="height">An optional function to calculate the height of the view.</param>

/// <param name="container">An optional ItemsView container for the view.</param>

/// <param name="fill">If true, the view will fill the available space; otherwise, it will not.</param>

Copilot · 2025-05-08T13:04:55Z

src/Controls/src/Core/Handlers/Items/Android/Adapters/EmptyViewAdapter.cs


+			if (item is string text)
+			{
+				Label label = new Label { Text = text };


[nitpick] A new branch has been added to handle string-based header/footer measurement using a Label. Adding an inline comment to explain why TemplateHelpers.GetHandler is called on the Label will help future maintainers understand this logic.

Suggested change

Label label = new Label { Text = text };

Label label = new Label { Text = text };

// Ensure the Label is initialized with a handler so it can be measured correctly.

rmarinho · 2025-05-08T13:30:37Z

src/Controls/src/Core/Handlers/Items/Android/Adapters/EmptyViewAdapter.cs


+			if (item is string text)
+			{
+				Label label = new Label { Text = text };


Doesn t it need a parent to get layout correctly ?

rmarinho · 2025-05-08T15:04:58Z

src/Controls/src/Core/Handlers/Items/Android/SimpleViewHolder.cs

-				textView.LayoutParameters = layoutParams;
+				// When displaying an EmptyView with Header and Footer, we need to account for the Header and Footer sizes in layout calculations.
+				// This prevents the EmptyView from occupying the full remaining space. 
+				Label label = new Label() { Text = text, VerticalOptions = LayoutOptions.Center, HorizontalOptions = LayoutOptions.Center };


I wonder if this should center the text horizontally

The base branch was changed.

For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes ## New Release: May 21, 2025 We're excited to announce a new release of .NET MAUI with several bug fixes and improvements across various platforms. ### Bug Fixes #### iOS - **Map Control**: Fixed crash when navigating to a page containing a map more than once (#29369) - **CarouselView**: Fixed bounce-back behavior when Loop=false, ensuring proper scrolling experience (#29318) - **UIView**: Fixed NullReferenceException for UIView not being in UIWindow (#29460) #### Windows - **CarouselView**: Fixed HorizontalScrollBarVisibility="Never" not working properly (#29343) - **UI Controls**: Fixed the color not being applied to the Expand/Collapse Chevron icon (#29140) #### Windows & macOS - **Modal Navigation**: Fixed issue where Disappearing event was not triggered when closing a window with a modal page (#29129) #### Android - **Modal Pages**: Improved inheritance of StatusBar and NavigationBar background colors (#28568) - **Footer Scrolling**: Fixed footer scrolling issues in list controls (#29381) - **Modal Pages**: Improved inheritance of StatusBar and NavigationBar background colors on modal pages (#28568) #### Cross-Platform - **CarouselView**: Fixed ItemsLayout runtime updates to ensure proper layout behavior (#29447) - **CollectionView**: Fixed various issues in CollectionView implementation (#29423) ### Testing Improvements - Added feature matrix UITest cases for CollectionView dynamic changes (#29424) ### Code Quality - Fixed code formatting issues across the codebase - Minor typo corrections (#29379) ### Contributors This release was made possible by the hard work of our dedicated team and community contributors. We'd like to extend our gratitude to everyone who has contributed to this release. ### Installation This update is available through NuGet and the .NET SDK. Update your projects to get access to these fixes. ### Known Issues Please refer to our issue tracker for any known issues and their workarounds. --- For more information about .NET MAUI, visit [the official documentation](https://docs.microsoft.com/dotnet/maui/).

Fixed-Footer-Scrolling-Issue

dcfdc8d

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels May 7, 2025

prakashKannanSf3972 changed the title ~~[Android] - Fix footer scrolling issue when EmptyView is a string in CollectionView~~ [Android] - Fix inconsistent footer scrolling when EmptyView is a string in CollectionView May 8, 2025

jsuarezruiz added platform/android area-controls-collectionview CollectionView, CarouselView, IndicatorView labels May 8, 2025

prakashKannanSf3972 marked this pull request as ready for review May 8, 2025 13:04

Copilot AI review requested due to automatic review settings May 8, 2025 13:04

prakashKannanSf3972 requested a review from a team as a code owner May 8, 2025 13:04

prakashKannanSf3972 requested review from mattleibow and rmarinho May 8, 2025 13:04

Copilot AI reviewed May 8, 2025

View reviewed changes

rmarinho reviewed May 8, 2025

View reviewed changes

rmarinho previously approved these changes May 8, 2025

View reviewed changes

dotnet deleted a comment from azure-pipelines bot May 8, 2025

PureWeen changed the base branch from main to inflight/current May 8, 2025 16:19

PureWeen approved these changes May 8, 2025

View reviewed changes

PureWeen merged commit 59251eb into dotnet:inflight/current May 8, 2025
102 of 114 checks passed

PureWeen pushed a commit that referenced this pull request May 9, 2025

Fixed-Footer-Scrolling-Issue (#29381)

26f8755

prakashKannanSf3972 mentioned this pull request May 13, 2025

Fixed Test case failure in PR 29473 - [2025/05/19] Candidate #29457

Merged

PureWeen pushed a commit that referenced this pull request May 13, 2025

Fixed-Footer-Scrolling-Issue (#29381)

c602d77

github-actions bot pushed a commit that referenced this pull request May 13, 2025

Fixed-Footer-Scrolling-Issue (#29381)

dde62b0

PureWeen pushed a commit that referenced this pull request May 14, 2025

Fixed-Footer-Scrolling-Issue (#29381)

8566d8d

PureWeen pushed a commit that referenced this pull request May 14, 2025

Fixed-Footer-Scrolling-Issue (#29381)

14270cb

github-actions bot pushed a commit that referenced this pull request May 15, 2025

Fixed-Footer-Scrolling-Issue (#29381)

b4c4893

PureWeen mentioned this pull request May 21, 2025

[2025/05/19] Candidate - In Flight Branch #29473

Merged

PureWeen pushed a commit that referenced this pull request May 21, 2025

Fixed-Footer-Scrolling-Issue (#29381)

e2fb92f

github-actions bot locked and limited conversation to collaborators Jun 8, 2025

PureWeen added this to the .NET 9 SR8 milestone Aug 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] - Fix inconsistent footer scrolling when EmptyView is a string in CollectionView#29381

[Android] - Fix inconsistent footer scrolling when EmptyView is a string in CollectionView#29381
PureWeen merged 1 commit intodotnet:inflight/currentfrom
prakashKannanSf3972:fix-28765

prakashKannanSf3972 commented May 7, 2025 •

edited

Loading

Uh oh!

jsuarezruiz commented May 8, 2025

Uh oh!

azure-pipelines bot commented May 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 8, 2025

Uh oh!

Copilot AI May 8, 2025

Uh oh!

rmarinho May 8, 2025

Uh oh!

rmarinho May 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -27,19 +27,19 @@ public void Recycle(ItemsView itemsView)
		itemsView.RemoveLogicalChild(View);
		}

+		/// <summary>
+		/// Creates a SimpleViewHolder containing a text-based view.
+		/// </summary>
+		/// <param name="text">The text to display in the view.</param>
+		/// <param name="context">The Android context used to create the view.</param>
+		/// <param name="width">An optional function to calculate the width of the view.</param>
+		/// <param name="height">An optional function to calculate the height of the view.</param>
+		/// <param name="container">An optional ItemsView container for the view.</param>
+		/// <param name="fill">If true, the view will fill the available space; otherwise, it will not.</param>

	Label label = new Label { Text = text };
	Label label = new Label { Text = text };
	// Ensure the Label is initialized with a handler so it can be measured correctly.

Conversation

prakashKannanSf3972 commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root Cause

Description of Change

Issues Fixed

Output

Uh oh!

jsuarezruiz commented May 8, 2025

Uh oh!

azure-pipelines bot commented May 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 8, 2025

Choose a reason for hiding this comment

Uh oh!

rmarinho May 8, 2025

Choose a reason for hiding this comment

Uh oh!

rmarinho May 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

prakashKannanSf3972 commented May 7, 2025 •

edited

Loading