Fix for [Windows] HorizontalScrollBarVisibility="Never" not working in CarouselView on Windows platform#29343
Merged
PureWeen merged 10 commits intodotnet:inflight/currentfrom May 13, 2025
Merged
Conversation
Contributor
|
Hey there @@SuthiYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
reviewed
May 6, 2025
| } | ||
| else | ||
| { | ||
| UpdateHorizontalScrollBarVisibility(); |
Contributor
There was a problem hiding this comment.
If both UpdateHorizontalScrollBarVisibility() and UpdateVerticalScrollBarVisibility() are always called together, could consolidate them into a single method.
Contributor
Author
There was a problem hiding this comment.
Hi @jsuarezruiz , I have included the UpdateScrollBarVisibility() method to handle both horizontal and vertical updates. Please review it and let me know if you have any feedback or concerns.
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
approved these changes
May 12, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2025
…n CarouselView on Windows platform (#29343) * Update ItemsViewHandler.Windows.cs * Update ItemsViewHandler.Windows.cs * Commit for ScrollBarVisibility * Testcase included * Update Issue15253.cs * Tes * testcases enabled * Update Issue15253.cs * Image updated * method change
PureWeen
pushed a commit
that referenced
this pull request
May 14, 2025
…n CarouselView on Windows platform (#29343) * Update ItemsViewHandler.Windows.cs * Update ItemsViewHandler.Windows.cs * Commit for ScrollBarVisibility * Testcase included * Update Issue15253.cs * Tes * testcases enabled * Update Issue15253.cs * Image updated * method change # Conflicts: # src/Controls/tests/TestCases.HostApp/Issues/Issue28098.xaml.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28098.cs
PureWeen
pushed a commit
that referenced
this pull request
May 14, 2025
…n CarouselView on Windows platform (#29343) * Update ItemsViewHandler.Windows.cs * Update ItemsViewHandler.Windows.cs * Commit for ScrollBarVisibility * Testcase included * Update Issue15253.cs * Tes * testcases enabled * Update Issue15253.cs * Image updated * method change
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2025
…n CarouselView on Windows platform (#29343) * Update ItemsViewHandler.Windows.cs * Update ItemsViewHandler.Windows.cs * Commit for ScrollBarVisibility * Testcase included * Update Issue15253.cs * Tes * testcases enabled * Update Issue15253.cs * Image updated * method change # Conflicts: # src/Controls/tests/TestCases.HostApp/Issues/Issue28098.xaml.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28098.cs
PureWeen
added a commit
that referenced
this pull request
May 21, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes ## New Release: May 21, 2025 We're excited to announce a new release of .NET MAUI with several bug fixes and improvements across various platforms. ### Bug Fixes #### iOS - **Map Control**: Fixed crash when navigating to a page containing a map more than once (#29369) - **CarouselView**: Fixed bounce-back behavior when Loop=false, ensuring proper scrolling experience (#29318) - **UIView**: Fixed NullReferenceException for UIView not being in UIWindow (#29460) #### Windows - **CarouselView**: Fixed HorizontalScrollBarVisibility="Never" not working properly (#29343) - **UI Controls**: Fixed the color not being applied to the Expand/Collapse Chevron icon (#29140) #### Windows & macOS - **Modal Navigation**: Fixed issue where Disappearing event was not triggered when closing a window with a modal page (#29129) #### Android - **Modal Pages**: Improved inheritance of StatusBar and NavigationBar background colors (#28568) - **Footer Scrolling**: Fixed footer scrolling issues in list controls (#29381) - **Modal Pages**: Improved inheritance of StatusBar and NavigationBar background colors on modal pages (#28568) #### Cross-Platform - **CarouselView**: Fixed ItemsLayout runtime updates to ensure proper layout behavior (#29447) - **CollectionView**: Fixed various issues in CollectionView implementation (#29423) ### Testing Improvements - Added feature matrix UITest cases for CollectionView dynamic changes (#29424) ### Code Quality - Fixed code formatting issues across the codebase - Minor typo corrections (#29379) ### Contributors This release was made possible by the hard work of our dedicated team and community contributors. We'd like to extend our gratitude to everyone who has contributed to this release. ### Installation This update is available through NuGet and the .NET SDK. Update your projects to get access to these fixes. ### Known Issues Please refer to our issue tracker for any known issues and their workarounds. --- For more information about .NET MAUI, visit [the official documentation](https://docs.microsoft.com/dotnet/maui/).
PureWeen
pushed a commit
that referenced
this pull request
May 21, 2025
…n CarouselView on Windows platform (#29343) * Update ItemsViewHandler.Windows.cs * Update ItemsViewHandler.Windows.cs * Commit for ScrollBarVisibility * Testcase included * Update Issue15253.cs * Tes * testcases enabled * Update Issue15253.cs * Image updated * method change # Conflicts: # src/Controls/tests/TestCases.HostApp/Issues/Issue28098.xaml.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28098.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Root Cause:
The
UpdateHorizontalScrollBarVisibilitymethod was being triggered before the ScrollViewer was initialized when modifying the HorizontalScrollbarVisibility for a CarouselView. This resulted in scrollbar is not updated properlyDescription of Change:
Ensured to update the
HorizontalScrollbarVisibilityandVerticalScrollbarVisibility, after the ScrollViewer is fully initialized. Once the ScrollViewer is confirmed to be non-null, updated the scrollbar visibility settings for both horizontal and vertical scrollbars accordingly.Issues Fixed
Fixes #15253
Tested the behaviour in the following platforms
Output Screenshot