[msbuild] Fix finding applicable simulator devices in GetMlaunchArguments task. by rolfbjarne · Pull Request #24610 · dotnet/macios

rolfbjarne · 2026-02-02T20:46:33Z

When we're dealing with an app that runs on both iPhone and iPad, we need to
list both iPhone and iPad simulators, not just iPad simulators.

This fixes an issue where we'd fail to find a simulator when specified by a udid if:

The app targets both iPhone and iPad.
The desired simulator is an iPhone.

The symptom would be this error, after 'dotnet run':

error MT1207: Could not find the simulator device type 'iPhone 4s'.

…ents task. When we're dealing with an app that runs on both iPhone and iPad, we need to list both iPhone and iPad simulators, not just iPad simulators. This fixes an issue where we'd fail to find a simulator when specified by a udid if: * The app targets both iPhone and iPad. * The desired simulator is an iPhone. The symptom would be this error, after 'dotnet run': > error MT1207: Could not find the simulator device type 'iPhone 4s'.

Copilot

Pull request overview

This PR fixes a bug in the GetMlaunchArguments MSBuild task where it failed to find iPhone simulators when the app targets both iPhone and iPad devices. The issue occurred because the code only looked for iPad simulators when IPhoneAndIPad was specified, excluding valid iPhone simulators from the search.

Changes:

Changed productFamily from a single string to productFamilies array to support multiple device families
Updated the IPhoneAndIPad case to include both "iPhone" and "iPad" product families instead of just "iPad"
Modified the XPath query to use an OR condition across all applicable product families

vs-mobiletools-engineering-service2 · 2026-02-03T12:34:49Z

✅ [CI Build #4ad1d10] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 4ad1d10dd5c6dafe9626556a4953fdc03570d40a [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T12:36:15Z

✅ [PR Build #4ad1d10] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 4ad1d10dd5c6dafe9626556a4953fdc03570d40a [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T13:14:28Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 4ad1d10dd5c6dafe9626556a4953fdc03570d40a [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T13:31:59Z

✅ [CI Build #4ad1d10] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 4ad1d10dd5c6dafe9626556a4953fdc03570d40a [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T13:46:05Z

💻 [CI Build #4ad1d10] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 4ad1d10dd5c6dafe9626556a4953fdc03570d40a [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T13:47:57Z

💻 [CI Build #4ad1d10] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 4ad1d10dd5c6dafe9626556a4953fdc03570d40a [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T13:48:02Z

💻 [CI Build #4ad1d10] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 4ad1d10dd5c6dafe9626556a4953fdc03570d40a [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T13:48:10Z

💻 [CI Build #4ad1d10] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 4ad1d10dd5c6dafe9626556a4953fdc03570d40a [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T13:50:15Z

💻 [CI Build #4ad1d10] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 4ad1d10dd5c6dafe9626556a4953fdc03570d40a [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T19:40:05Z

🚀 [CI Build #4ad1d10] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download

Pipeline on Agent
Hash: 4ad1d10dd5c6dafe9626556a4953fdc03570d40a [PR build]

…r devices in GetMlaunchArguments task. (#24611) When we're dealing with an app that runs on both iPhone and iPad, we need to list both iPhone and iPad simulators, not just iPad simulators. This fixes an issue where we'd fail to find a simulator when specified by a udid if: * The app targets both iPhone and iPad. * The desired simulator is an iPhone. The symptom would be this error, after 'dotnet run': > error MT1207: Could not find the simulator device type 'iPhone 4s'. Backport of #24610.

rolfbjarne requested review from emaf and mauroa as code owners February 2, 2026 20:46

rolfbjarne requested a review from Copilot February 2, 2026 20:46

Copilot AI reviewed Feb 2, 2026

View reviewed changes

rolfbjarne mentioned this pull request Feb 2, 2026

[release/11.0.1xx-preview1] [msbuild] Fix finding applicable simulator devices in GetMlaunchArguments task. #24611

Merged

dalexsoto approved these changes Feb 2, 2026

View reviewed changes

dalexsoto and others added 2 commits February 2, 2026 18:34

Merge branch 'main' into dev/rolf/msbuild-select-devices-fix

9a2019e

Auto-format source code

80b37c3

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/rolf/msbuild-select-devices-fix

4ad1d10

emaf approved these changes Feb 3, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne enabled auto-merge (squash) February 3, 2026 15:29

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 64e2b82 into main Feb 3, 2026
47 checks passed

Conversation

rolfbjarne commented Feb 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 3, 2026

✅ [CI Build #4ad1d10] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

✅ [PR Build #4ad1d10] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

✅ [CI Build #4ad1d10] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #4ad1d10] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #4ad1d10] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #4ad1d10] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #4ad1d10] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #4ad1d10] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 3, 2026

🚀 [CI Build #4ad1d10] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants