[release/11.0.1xx-preview1] [msbuild] Fix finding applicable simulator devices in GetMlaunchArguments task. by rolfbjarne · Pull Request #24611 · dotnet/macios

rolfbjarne · 2026-02-02T20:47:44Z

When we're dealing with an app that runs on both iPhone and iPad, we need to
list both iPhone and iPad simulators, not just iPad simulators.

This fixes an issue where we'd fail to find a simulator when specified by a udid if:

The app targets both iPhone and iPad.
The desired simulator is an iPhone.

The symptom would be this error, after 'dotnet run':

error MT1207: Could not find the simulator device type 'iPhone 4s'.

Backport of #24610.

…ents task. When we're dealing with an app that runs on both iPhone and iPad, we need to list both iPhone and iPad simulators, not just iPad simulators. This fixes an issue where we'd fail to find a simulator when specified by a udid if: * The app targets both iPhone and iPad. * The desired simulator is an iPhone. The symptom would be this error, after 'dotnet run': > error MT1207: Could not find the simulator device type 'iPhone 4s'.

Copilot

Pull request overview

This PR fixes a bug in the GetMlaunchArguments MSBuild task where simulator device lookup failed for apps targeting both iPhone and iPad when the specified simulator was an iPhone. The fix ensures that both iPhone and iPad simulators are queried when the app supports both device types.

Changes:

Modified the device type lookup logic to support multiple product families instead of a single family
Updated the XPath query to search for simulators matching any of the applicable product families

dalexsoto · 2026-02-02T23:35:19Z

/azp run

azure-pipelines · 2026-02-02T23:35:37Z

Azure Pipelines successfully started running 1 pipeline(s).

…610-release/11.0.1xx-preview1-2026-02-02

vs-mobiletools-engineering-service2 · 2026-02-03T16:49:31Z

✅ [CI Build #b4b5760] Build passed (Build packages) ✅

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T16:57:39Z

✅ [PR Build #b4b5760] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T17:46:36Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T17:48:22Z

✅ [CI Build #b4b5760] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T18:01:55Z

💻 [CI Build #b4b5760] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T18:15:03Z

💻 [CI Build #b4b5760] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T18:27:42Z

💻 [CI Build #b4b5760] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-04T16:34:43Z

🚀 [CI Build #b4b5760] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 135 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 9 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 17 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 13 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

rolfbjarne requested review from emaf and mauroa as code owners February 2, 2026 20:47

rolfbjarne requested a review from Copilot February 2, 2026 20:47

Copilot AI reviewed Feb 2, 2026

View reviewed changes

dalexsoto approved these changes Feb 2, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits February 3, 2026 16:30

Merge branch 'release/11.0.1xx-preview1' into dev/rolf/backport-pr-24…

891148a

…610-release/11.0.1xx-preview1-2026-02-02

Trigger CI

e6d50d5

rolfbjarne enabled auto-merge (squash) February 3, 2026 15:34

Auto-format source code

b4b5760

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 5768545 into release/11.0.1xx-preview1 Feb 4, 2026
40 checks passed

Conversation

rolfbjarne commented Feb 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

dalexsoto commented Feb 2, 2026

Uh oh!

azure-pipelines bot commented Feb 2, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 3, 2026

✅ [CI Build #b4b5760] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

✅ [PR Build #b4b5760] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 3, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

✅ [CI Build #b4b5760] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #b4b5760] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #b4b5760] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #b4b5760] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 4, 2026

🚀 [CI Build #b4b5760] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants