[msbuild] Verify Mac Catalyst apps like we verify macOS apps. Fixes #17829. by rolfbjarne · Pull Request #17835 · dotnet/macios

rolfbjarne · 2023-03-17T13:28:06Z

For Mac Catalyst apps we must verify the code signature like we do it for
macOS apps. Fixes _CodesignVerify target fails when publishing a .NET MAUI MacCat app for outside the App Store #17829.
Enable nullability and fix code accordingly.
Merge the CodesignVerify and CodesignVerifyTaskBase classes to simplify the
code.

Submission test is added as well:

…otnet#17829. * For Mac Catalyst apps we must verify the code signature like we do it for macOS apps. Fixes dotnet#17829. * Enable nullability and fix code accordingly. * Merge the CodesignVerify and CodesignVerifyTaskBase classes to simplify the code. Submission test is added as well: * xamarin/maccore#2656 * xamarin/SubmissionSamples#51 Fixes dotnet#17829.

vs-mobiletools-engineering-service2 · 2023-03-21T08:19:25Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: cbfbc4f6e6db6393be1d6322fe765dd917241c7a [PR build]

vs-mobiletools-engineering-service2 · 2023-03-21T08:41:04Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: cbfbc4f6e6db6393be1d6322fe765dd917241c7a [PR build]

vs-mobiletools-engineering-service2 · 2023-03-21T08:43:24Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: cbfbc4f6e6db6393be1d6322fe765dd917241c7a [PR build]

vs-mobiletools-engineering-service2 · 2023-03-21T08:45:15Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: cbfbc4f6e6db6393be1d6322fe765dd917241c7a [PR build]

vs-mobiletools-engineering-service2 · 2023-03-21T08:53:30Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-015.Ventura
Hash: cbfbc4f6e6db6393be1d6322fe765dd917241c7a [PR build]

vs-mobiletools-engineering-service2 · 2023-03-21T12:10:54Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: cbfbc4f6e6db6393be1d6322fe765dd917241c7a [PR build]

rolfbjarne · 2023-03-21T17:20:19Z

/sudo backport release/7.0.2xx

rolfbjarne · 2023-03-21T17:21:06Z

/sudo backport release/6.0.4xx-xcode14.2

vs-mobiletools-engineering-service2 · 2023-03-21T17:21:09Z

Backport Job to branch release/7.0.2xx Created! The magic is happening here

rolfbjarne · 2023-03-21T17:21:15Z

/sudo backport release/7.0.1xx-xcode14.2

vs-mobiletools-engineering-service2 · 2023-03-21T17:21:34Z

Backport Job to branch release/6.0.4xx-xcode14.2 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-03-21T17:21:55Z

Backport Job to branch release/7.0.1xx-xcode14.2 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-03-21T17:23:17Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7503768 for more details.

vs-mobiletools-engineering-service2 · 2023-03-21T17:24:05Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7503770 for more details.

vs-mobiletools-engineering-service2 · 2023-03-21T17:24:05Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7503772 for more details.

…e verify macOS apps. Fixes #17829. (#17868) * For Mac Catalyst apps we must verify the code signature like we do it for macOS apps. Fixes #17829. * Enable nullability and fix code accordingly. * Merge the CodesignVerify and CodesignVerifyTaskBase classes to simplify the code. Submission test is added as well: * xamarin/maccore#2656 * xamarin/SubmissionSamples#51 Fixes #17829. Backport of #17835 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

…acOS apps. Fixes #17829. (#17867) * For Mac Catalyst apps we must verify the code signature like we do it for macOS apps. Fixes #17829. * Enable nullability and fix code accordingly. * Merge the CodesignVerify and CodesignVerifyTaskBase classes to simplify the code. Submission test is added as well: * xamarin/maccore#2656 * xamarin/SubmissionSamples#51 Fixes #17829. Backport of #17835

…e verify macOS apps. Fixes #17829. (#17869) * For Mac Catalyst apps we must verify the code signature like we do it for macOS apps. Fixes #17829. * Enable nullability and fix code accordingly. * Merge the CodesignVerify and CodesignVerifyTaskBase classes to simplify the code. Submission test is added as well: * xamarin/maccore#2656 * xamarin/SubmissionSamples#51 Fixes #17829. Backport of #17835

rolfbjarne requested review from emaf and mauroa as code owners March 17, 2023 13:28

rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Mar 17, 2023

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Mar 17, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

haritha-mohan approved these changes Mar 20, 2023

View reviewed changes

tj-devel709 approved these changes Mar 20, 2023

View reviewed changes

Merge branch 'main' into issue-17829

cbfbc4f

emaf approved these changes Mar 21, 2023

View reviewed changes

rolfbjarne merged commit bfd87e4 into dotnet:main Mar 21, 2023

rolfbjarne deleted the issue-17829 branch March 21, 2023 17:20

vs-mobiletools-engineering-service2 mentioned this pull request Mar 21, 2023

[release/7.0.2xx] [msbuild] Verify Mac Catalyst apps like we verify macOS apps. Fixes #17829. #17867

Merged

This was referenced Mar 21, 2023

[release/6.0.4xx-xcode14.2] [msbuild] Verify Mac Catalyst apps like we verify macOS apps. Fixes #17829. #17868

Merged

[release/7.0.1xx-xcode14.2] [msbuild] Verify Mac Catalyst apps like we verify macOS apps. Fixes #17829. #17869

Merged

Conversation

rolfbjarne commented Mar 17, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 21, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 21, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 21, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 21, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 21, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 21, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

rolfbjarne commented Mar 21, 2023

Uh oh!

rolfbjarne commented Mar 21, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 21, 2023

Uh oh!

rolfbjarne commented Mar 21, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 21, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 21, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 21, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 21, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants