Skip to content

[release/7.0.2xx] [msbuild] Verify Mac Catalyst apps like we verify macOS apps. Fixes #17829.#17867

Merged
rolfbjarne merged 1 commit intodotnet:release/7.0.2xxfrom
vs-mobiletools-engineering-service2:backport-pr-17835-to-release/7.0.2xx
Mar 22, 2023
Merged

[release/7.0.2xx] [msbuild] Verify Mac Catalyst apps like we verify macOS apps. Fixes #17829.#17867
rolfbjarne merged 1 commit intodotnet:release/7.0.2xxfrom
vs-mobiletools-engineering-service2:backport-pr-17835-to-release/7.0.2xx

Conversation

@vs-mobiletools-engineering-service2
Copy link
Collaborator

@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 commented Mar 21, 2023

Submission test is added as well:

Fixes #17829.

Backport of #17835

@rolfbjarne
[msbuild] Verify Mac Catalyst apps like we verify macOS apps. Fixes d…
5f7aea8 
…otnet#17829.

* For Mac Catalyst apps we must verify the code signature like we do it for
  macOS apps. Fixes dotnet#17829.
* Enable nullability and fix code accordingly.
* Merge the CodesignVerify and CodesignVerifyTaskBase classes to simplify the
  code.

Submission test is added as well:

* xamarin/maccore#2656
* xamarin/SubmissionSamples#51

Fixes dotnet#17829.
@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 added bug If an issue is a bug or a pull request a bug fix backported labels Mar 21, 2023
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Mar 21, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 5f7aea8d0fcec38793c8e077dcdb68f32d41ee9d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Mar 21, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 5f7aea8d0fcec38793c8e077dcdb68f32d41ee9d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Mar 21, 2023

✅ API diff for current PR / commit

NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

.NET (No breaking changes)
  • iOS: vsdrops gist (No breaking changes)
  • tvOS: (empty diff detected)
  • MacCatalyst: vsdrops gist (No breaking changes)
  • macOS: vsdrops gist (No breaking changes)
  • Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops (could not create gist: file 'D:\a\1\s\change-detection\results\stable-api-comparison\diff\dotnet\iOS-MacCatalyst-diff\Microsoft.iOS.Ref\ref\net7.0\Microsoft.iOS.MacCatalyst.md' does not exist)

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 5f7aea8d0fcec38793c8e077dcdb68f32d41ee9d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Mar 21, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1200.Ventura
Hash: 5f7aea8d0fcec38793c8e077dcdb68f32d41ee9d [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Mar 22, 2023

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 77 tests passed 🎉

Tests counts

⚠️ bcl: No tests selected. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ framework: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 4 tests passed. Html Report (VSDrops) Download
⚠️ install_source: No tests selected. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
⚠️ mac_binding_project: No tests selected. Html Report (VSDrops) Download
⚠️ mmp: No tests selected. Html Report (VSDrops) Download
⚠️ mononative: No tests selected. Html Report (VSDrops) Download
✅ monotouch: All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
⚠️ mtouch: No tests selected. Html Report (VSDrops) Download
⚠️ xammac: No tests selected. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne rolfbjarne merged commit 15c7939 into dotnet:release/7.0.2xx Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@emaf emaf Awaiting requested review from emaf emaf is a code owner

@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

Assignees

No one assigned

Labels

backported bug If an issue is a bug or a pull request a bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne