Add support for generic attributes#2980
Merged
sbomer merged 2 commits intodotnet:mainfrom Aug 23, 2022
Merged
Conversation
vitek-karas
approved these changes
Aug 23, 2022
Member
vitek-karas
left a comment
There was a problem hiding this comment.
Looks good - maybe create an issue to add tests which do some simple validation of data flow stuff on the generic instantiations of attributes.
I'm not worried about linker, but analyzer and AoT might have problems.
sbomer
added a commit
to sbomer/linker
that referenced
this pull request
Aug 23, 2022
* Add generic attribute tests * Update cecil
sbomer
added a commit
that referenced
this pull request
Aug 23, 2022
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
* Add generic attribute tests * Update cecil Commit migrated from dotnet/linker@e2dba52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on dotnet/cecil#36.
Fixes #2963.