Add support for generic attributes#36
Merged
marek-safar merged 2 commits intodotnet:mainfrom Aug 23, 2022
Merged
Conversation
Member
Author
|
@MichalStrehovsky @vitek-karas @marek-safar PTAL (I can't add reviewers) |
MichalStrehovsky
approved these changes
Aug 17, 2022
Member
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Not an expert, but looks reasonable. Nice that it already worked for the named arguments case.
Does the test also test writing? Though, I'm not too concerned about that since I assume we'll have writing coverage in the linker repo.
Member
Author
|
Yes, |
To satisfy PEVerify
vitek-karas
approved these changes
Aug 22, 2022
Member
Author
|
@marek-safar would you be able to merge this? I don't have permission. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for generic attributes, added in C# 10. This is needed to fix a linker crash on runtime tests that used generic attributes: dotnet/linker#2963
Upstreaming this in jbevain#871.