VS2017 RC - Get correct options for scripts#1865
Merged
dsyme merged 1 commit intodotnet:masterfrom Nov 27, 2016
Merged
Conversation
Contributor
Author
|
This build on #1855 hence the large number of commits |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Prior to this, we never update the compiler options stored for scripts. This means that as you add #r or #load the compilation options aren't updated. This PR updates the options in the semantic analysis phase. We can't update them on every request for options because it is too expensive. This fixes some aspects of dotnet#1808 but the underlying problem of not reacting to file update events in dependencies is not fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this, we never update the compiler options stored for scripts. This means that as you add
#ror#loadthe compilation options aren't updated.This PR updates the options in the semantic analysis phase. We can't update them on every request for options because it is too expensive.
This fixes some aspects of #1808 but the underlying problem of not reacting to file update events in dependencies is not fixed.