Conversation
|
Fantastic |
|
I've now added some not-completely-trivial testing for this, see https://github.com/Microsoft/visualfsharp/pull/1855/files#diff-b9b8a5c1cfbb79988bfa13d92ce02993R61 I believe that suffices for smoke testing at this point |
|
This is ready to go in, once CI is green. |
|
@vasily-kirichenko @forki Please review this? thanks |
|
Why is it changing the parser? |
It gives accurate method info when pressing Tests added at 6796ead |
|
Found a bug: let _ = System.DateTimeNote that this line is the last line in the file, there are no, even empty, lines below it. No signature help appear. |
|
Great, thank you |
|
@vasily-kirichenko Fix for that test case is included, also fix for the GTD bug. And test cases for both |
This implements signature help (method overload tips and parameter info). dotnet#1767. Also fixes dotnet#1856 This is mostly just wiring up the necessary things and copying across some of the nitty-gritty detail from the old language service. Some additional information was propagated such as HasParamArrayArg.
This implements signature help (method overload tips and parameter info). #1767. Also fixes #1856
This is mostly just wiring up the necessary things and copying across some of the nitty-gritty detail from the old language service. Some additional information was propagated such as HasParamArrayArg.
We already have lots of unit tests, but just below the level being exercised here. I will endeavor to add at least one smoke test at this level.
Here's a screen capture showing parity with VS2015