Use External Access wrapper of IWorkspaceProjectContextFactory#13514
Merged
KevinRansom merged 3 commits intodotnet:mainfrom Jul 24, 2022
Merged
Use External Access wrapper of IWorkspaceProjectContextFactory#13514KevinRansom merged 3 commits intodotnet:mainfrom
KevinRansom merged 3 commits intodotnet:mainfrom
Conversation
525ab84 to
c046b8d
Compare
Contributor
|
This breaks usage of "main" with VS 17.2.6 or 17.3 preview 5.0, which means contributors can't contribute to the Visual F# bits ("main" is meant to assume install into latest non-Preview VS). So @vzarytovskii says this one should have gone to the preview release branch. Suggestion is to revert from main and apply to the preview release branch then reconcile when they flow together |
Contributor
|
I'd submit a revert request but "Revert" doesn't work so simply. |
Member
Yep, makes sense. Let's revert it and re-apply (cherry-pick) to the 17.4 |
vzarytovskii
added a commit
to vzarytovskii/fsharp
that referenced
this pull request
Aug 1, 2022
dotnet#13514)" This reverts commit 80b5503.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes direct usage of internal Roslyn APIs. Instead uses wrappers added to External Access layer in Roslyn: dotnet/roslyn#62646
Can only be merged after the above PR is inserted into VS.
May need to be merged into a different branch since the latest Roslyn build is required.