Revert "Use External Access wrapper of IWorkspaceProjectContextFactory (#13514)"#13608
Closed
vzarytovskii wants to merge 4 commits intodotnet:mainfrom
Closed
Revert "Use External Access wrapper of IWorkspaceProjectContextFactory (#13514)"#13608vzarytovskii wants to merge 4 commits intodotnet:mainfrom
vzarytovskii wants to merge 4 commits intodotnet:mainfrom
Conversation
Member
Author
|
Ok revert didn't fix the issue with deploying vsix into latest 17.3, it seems other packages upgrades we did may have affected it. |
Member
Author
|
Init-only and required properties feature also has updated packages (Roslyn ones, which resulted in upgrade of VS ones too). cc @dsyme |
Member
Author
|
I guess we should just wait for 17.4 to release, otherwise all the reverts will get messy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 80b5503.
Reason is that otherwise,
vsixis not deployable to 17.2 and 17.3.Once this one flows into
release/dev17.4, I will cherry-pick the original commit into17.4.