fix 11620 #11755
Merged
fix 11620 #11755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIHan
approved these changes
Jun 30, 2021
Contributor
|
@jonsequitur should we try to put this fix into servicing for 16.10? |
Contributor
Author
|
Two failing tests: The first is benign, some mistak in signature printing. For the second I may separate out the fix for units of measure found via the additional testing |
Merged
Contributor
Author
|
@TIHan @jonsequitur I strongly expect we'll need this as a servicing fix. The bug would have been caught by our existing test suite if the |
added 2 commits
June 30, 2021 23:20
Contributor
Author
|
@TIHan @jonsequitur Will leave the servicing fix and branch propagation in your hands :) |
vzarytovskii
pushed a commit
that referenced
this pull request
Jul 1, 2021
dsyme
added a commit
that referenced
this pull request
Aug 12, 2021
* fix 11620 * reinstate debug mode testing * remove assert in debug code * merge main * Update IlxGen.fs * Update IlxGen.fs * Update FSharp.Compiler.Service.Tests.fsproj * Update FSharp.Test.Utilities.fsproj * Update FSharp.Compiler.Service.Tests.fsproj * Update FSharp.Compiler.Service.Tests.fsproj * Update tests.fs * fix test * add extra tests Co-authored-by: Don Syme <donsyme@fastmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--optimize-testing for some key test suites in tests/fsharp/core. If this was enabled we would have avoided this regression. It used to be enabled a long time ago but somewhere along the way we dropped it.genericmeasuresthat was revealed through (2)Note that because of slow compilation speeds in repeatedly invoking the external
fscprocess intests/fsharp/coretests this will add 5min or so to the execution of theFSharpSuitetests, depending on the speed of your system. We should move this test suite to use in-memory compilation via FCS rather than compilation via the .NET SDK.