Skip to content

second part of #11755 #11763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsyme merged 17 commits into from
Aug 12, 2021
Merged

second part of #11755 #11763

dsyme merged 17 commits into from
Aug 12, 2021

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Jun 30, 2021

#11755 contained two fixes - the second noticed when I ramped up the testing for debug mode code.

However we want to take the minimal fix for the regression, and the second bug fix is not complete

So this is tracking the second bug fix

@dsyme dsyme mentioned this pull request Aug 10, 2021
Closed
@dsyme dsyme closed this Aug 11, 2021
@dsyme dsyme reopened this Aug 11, 2021
@dsyme
Copy link
Contributor Author

dsyme commented Aug 12, 2021

Random unrelated test failure

2021-08-12T11:45:58.1366610Z [xUnit.net 00:01:37.43]     FSharp.Core.UnitTests.Control.AsyncModule.AwaitWaitHandle.Timeout [FAIL]
2021-08-12T11:45:58.7229320Z   Failed FSharp.Core.UnitTests.Control.AsyncModule.AwaitWaitHandle.Timeout [1 s]
2021-08-12T11:45:58.7233710Z   Error Message:
2021-08-12T11:45:58.7234660Z    Expected faster timeout than 1505 ms
2021-08-12T11:45:58.7235730Z Expected: True
2021-08-12T11:45:58.7236740Z Actual:   False
2021-08-12T11:45:58.7237720Z   Stack Trace:
2021-08-12T11:45:58.7238960Z      at FSharp.Core.UnitTests.Control.AsyncModule.AwaitWaitHandle.Timeout() in /Users/runner/work/1/s/tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncModule.fs:line 232

@dsyme dsyme merged commit 96e1782 into dotnet:main Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

+2 more reviewers

@TIHan TIHan TIHan approved these changes

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dsyme @vzarytovskii @TIHan @KevinRansom