Merged
Conversation
- Add an explicit flag for post-build signing - In-build signing is only supported on Windows. This repo creates some packages on Mac and Linux, and at the moment they can only be created on those platforms. When post build signing isn't enabled, download the artifacts for those platforms and run the sign and publish phases of the build. - Update the cert for the MSIs to be the .NET Cert - Move the PostBuildSIgn flag into the YAML so it can be used in template expressions - Pass -sign (harmless if post-build sign is on) in all ci cases. - Always publish even on PRs, there's no harm in it.
Member
Author
|
PB sign test: https://dev.azure.com/dnceng/internal/_build/results?buildId=1919296&view=results Note that in-build will fail until signing approval is obtained. |
akoeplinger
approved these changes
Aug 5, 2022
radical
added a commit
to radical/emsdk
that referenced
this pull request
Aug 11, 2022
In the commit mentioned at the end, a new variable was added
conditionally:
```yml
# If post build signing, then OSX and Linux don't publish during their main pass. Otherwise, always publish
- ${{ if eq(variables['PostBuildSign'], 'true') }}:
- name: _NonWindowsInternalPublishArg
value: -publish
```
.. but this resulted in the variable not getting defined at all in the
final yaml. I think the reason is that you can't define a variable based
on a the value of another variable, at yaml expansion time. So, access
the variable at run time.
```
commit b36ce43
Author: Matt Mitchell <mmitche@microsoft.com>
Date: Fri Aug 5 14:05:37 2022 -0700
Add support for in-build signing (dotnet#164)
```
akoeplinger
added a commit
that referenced
this pull request
Aug 11, 2022
In the PR #164 a new variable was added conditionally: ```yml # If post build signing, then OSX and Linux don't publish during their main pass. Otherwise, always publish - ${{ if eq(variables['PostBuildSign'], 'true') }}: - name: _NonWindowsInternalPublishArg value: -publish ``` .. but this resulted in the variable not getting defined at all in the final yaml. We need to move the if to the variable _value_ instead. Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.