Fix publishing for non-windows platforms#167
Merged
akoeplinger merged 4 commits intodotnet:mainfrom Aug 11, 2022
Merged
Conversation
In the commit mentioned at the end, a new variable was added
conditionally:
```yml
# If post build signing, then OSX and Linux don't publish during their main pass. Otherwise, always publish
- ${{ if eq(variables['PostBuildSign'], 'true') }}:
- name: _NonWindowsInternalPublishArg
value: -publish
```
.. but this resulted in the variable not getting defined at all in the
final yaml. I think the reason is that you can't define a variable based
on a the value of another variable, at yaml expansion time. So, access
the variable at run time.
```
commit b36ce43
Author: Matt Mitchell <mmitche@microsoft.com>
Date: Fri Aug 5 14:05:37 2022 -0700
Add support for in-build signing (dotnet#164)
```
akoeplinger
approved these changes
Aug 11, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the PR #164 a new variable was added conditionally:
.. but this resulted in the variable not getting defined at all in the final yaml.
We need to move the if to the variable value instead.
FYI @mmitche