Throw for empty strings in primitive collection columns#32924
Merged
ajcvickers merged 1 commit intomainfrom Jan 26, 2024
Merged
Throw for empty strings in primitive collection columns#32924ajcvickers merged 1 commit intomainfrom
ajcvickers merged 1 commit intomainfrom
Conversation
roji
reviewed
Jan 25, 2024
Contributor
Author
|
You're right; I didn't realize the empty string was invalid JSON. |
967dc60 to
7c9e269
Compare
Contributor
Author
|
Updated to throw. |
roji
approved these changes
Jan 26, 2024
| <!-- | ||
| Microsoft ResX Schema | ||
| <!-- |
Member
There was a problem hiding this comment.
nit: unrelated whitespace changes (I get this too all of the time)
Contributor
Author
There was a problem hiding this comment.
Yeah, it's because the T4 that we generate from does not create code that conforms to our formatting, so whenever the file is opened in an editor, it changes from what was generated by T4.
Member
There was a problem hiding this comment.
Yeah, I remove the changes (git checkout -p) every time as well. It sucks.
ajcvickers
added a commit
that referenced
this pull request
Jan 26, 2024
maumar
pushed a commit
that referenced
this pull request
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32896