[release/8.0] Throw for empty strings in primitive collection columns#32928
Merged
maumar merged 2 commits intorelease/8.0from Feb 7, 2024
Merged
[release/8.0] Throw for empty strings in primitive collection columns#32928maumar merged 2 commits intorelease/8.0from
maumar merged 2 commits intorelease/8.0from
Conversation
roji
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #32924
Fixes #32896
Description
The empty string is not valid JSON. EF will never write this, but if a database column contains the empty string, then EF should throw.
Customer impact
Hang when using a column containing an empty string as a primitive collection.
How found
Customer reported on 8.
Regression
No, primitive collections are a new feature in 8.
Testing
Tests added.
Risk
Low. Quirked.