Use 'PortableTargetRid' property for the portable rid for the target.#1130
Merged
ViktorHofer merged 11 commits intodotnet:mainfrom Jun 18, 2025
Merged
Use 'PortableTargetRid' property for the portable rid for the target.#1130ViktorHofer merged 11 commits intodotnet:mainfrom
ViktorHofer merged 11 commits intodotnet:mainfrom
Conversation
tmds
commented
Jun 12, 2025
Member
|
Please revert all the eng/common updates except the ones under src/arcade/eng/common. The arcade one backflows to repos. The VMR root eng/common folder gets updated with the next re-bootstrap. |
tmds
commented
Jun 12, 2025
tmds
commented
Jun 12, 2025
Member
Author
|
I re-opened the PR to restart CI because the unified-build pipeline got canceled. |
Member
Author
It failed the same way. |
Member
|
That's an unrelated issue (OOM not timeout): #969 |
tmds
commented
Jun 12, 2025
src/runtime/src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
Show resolved
Hide resolved
tmds
commented
Jun 12, 2025
Member
Author
|
@ViktorHofer @jkoritzinsky @akoeplinger this is up for review. |
Member
Author
|
@ViktorHofer @jkoritzinsky @akoeplinger can you take a look? This is mostly a rename and some simplifications. I've eagerly updated the repos. I can revert the things you'd rather keep as they were. |
Member
|
/azp run dotnet-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ViktorHofer
approved these changes
Jun 18, 2025
akoeplinger
pushed a commit
to dkurepa/dotnet
that referenced
this pull request
Jul 3, 2025
…dotnet#1130) (cherry picked from commit caf8866)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #402 (comment).
@ViktorHofer @jkoritzinsky @akoeplinger ptal.