Adjust required members visibility specification#6190
Merged
333fred merged 2 commits intodotnet:mainfrom Jun 14, 2022
Merged
Conversation
The existing accessibility rules for required members allow protected members inside protected classes, breaking the intention of the rule. This update corrects the wording to prevent this.
5c6b74d to
a2483e4
Compare
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jun 1, 2022
… enforcement Implements the spec change in dotnet/csharplang#6190. Fixes dotnet#61527 and dotnet#61528.
RikkiGibson
approved these changes
Jun 1, 2022
| ### Accessibility | ||
|
|
||
| It is an error to mark a member required if the member is less accessible than the member's containing type. The member must also be settable by consumers, meaning that: | ||
| It is an error to mark a member required if the member cannot be set in any context where the containing type is visible. The member must also be settable by consumers, meaning that: |
Member
There was a problem hiding this comment.
nit: The member must also be settable by consumers seems redundant now.
jcouv
approved these changes
Jun 14, 2022
333fred
added a commit
to dotnet/roslyn
that referenced
this pull request
Jun 14, 2022
… enforcement (#61643) * Calculate containing type effective accessibility for required member enforcement Implements the spec change in dotnet/csharplang#6190. Fixes #61527 and #61528.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing accessibility rules for required members allow protected members inside protected classes, breaking the intention of the rule. This update corrects the wording to prevent this.