Calculate containing type effective accessibility for required member enforcement#61643
Merged
333fred merged 4 commits intodotnet:mainfrom Jun 14, 2022
Merged
Calculate containing type effective accessibility for required member enforcement#61643333fred merged 4 commits intodotnet:mainfrom
333fred merged 4 commits intodotnet:mainfrom
Conversation
… enforcement Implements the spec change in dotnet/csharplang#6190. Fixes dotnet#61527 and dotnet#61528.
Member
|
Can |
Member
Author
|
No, that helper is about relating type symbol visibility. We need to calculate the minimum required visibility for a member. |
Youssef1313
reviewed
Jun 2, 2022
AlekseyTs
reviewed
Jun 2, 2022
Contributor
|
Done with review pass (commit 1), tests are just glanced over. |
Member
Author
|
@AlekseyTs please take another look. |
AlekseyTs
reviewed
Jun 2, 2022
Contributor
|
Done with review pass (commit 2) |
AlekseyTs
reviewed
Jun 3, 2022
Contributor
|
Done with review pass (commit 3) |
Member
Author
|
@AlekseyTs please take another look. |
Member
Author
|
@dotnet/roslyn-compiler for a second review please. |
Member
Author
|
https://github.com/orgs/dotnet/teams/roslyn-compiler for a second review please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the spec change in dotnet/csharplang#6190. Fixes #61527 and #61528.