This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove Socket.InnerSafeCloseSocket#41888
Merged
stephentoub merged 5 commits intodotnet:masterfrom Oct 23, 2019
Merged
Conversation
stephentoub
reviewed
Oct 21, 2019
src/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 21, 2019
src/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 21, 2019
src/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.Windows.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Oct 21, 2019
Member
stephentoub
left a comment
There was a problem hiding this comment.
Thanks for working on this. It's great how much code we get to delete, and that we can avoid the unnecessary level of safe handles.
Member
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
tmds
commented
Oct 21, 2019
src/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 21, 2019
src/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.Windows.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 21, 2019
src/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.Windows.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 21, 2019
src/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 22, 2019
src/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 22, 2019
src/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 22, 2019
src/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 22, 2019
src/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated
Show resolved
Hide resolved
Member
|
Thanks! |
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/coreclr
that referenced
this pull request
Oct 23, 2019
* Remove Socket.InnerSafeCloseSocket * Move IsInvalid checks in SetHandle function * PR feedback * Remove unnecessary 'SocketPal.' * Remove SafeSocketHandle.SetHandle Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Oct 23, 2019
* Remove Socket.InnerSafeCloseSocket * Move IsInvalid checks in SetHandle function * PR feedback * Remove unnecessary 'SocketPal.' * Remove SafeSocketHandle.SetHandle Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Oct 23, 2019
* Remove Socket.InnerSafeCloseSocket * Move IsInvalid checks in SetHandle function * PR feedback * Remove unnecessary 'SocketPal.' * Remove SafeSocketHandle.SetHandle Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
tannergooding
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Oct 23, 2019
* Remove Socket.InnerSafeCloseSocket * Move IsInvalid checks in SetHandle function * PR feedback * Remove unnecessary 'SocketPal.' * Remove SafeSocketHandle.SetHandle Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Oct 23, 2019
* Remove Socket.InnerSafeCloseSocket * Move IsInvalid checks in SetHandle function * PR feedback * Remove unnecessary 'SocketPal.' * Remove SafeSocketHandle.SetHandle Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
vargaz
pushed a commit
to mono/mono
that referenced
this pull request
Oct 24, 2019
* Apply SuppressGCAttribute to some SPCL functions. (dotnet/coreclr#27369) Apply SuppressGCAttribute to some SPCL functions. Only insert GC_POLL in first morph call. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> * Remove unused methods (dotnet/coreclr#27370) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> * Move Matrix3x2/4x4, Plan, and Quaternion to the shared CoreLib partition (#42021) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> * Remove Socket.InnerSafeCloseSocket (dotnet/corefx#41888) * Remove Socket.InnerSafeCloseSocket * Move IsInvalid checks in SetHandle function * PR feedback * Remove unnecessary 'SocketPal.' * Remove SafeSocketHandle.SetHandle Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Remove Socket.InnerSafeCloseSocket * Move IsInvalid checks in SetHandle function * PR feedback * Remove unnecessary 'SocketPal.' * Remove SafeSocketHandle.SetHandle Commit migrated from dotnet/corefx@092dff2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/41551
@stephentoub @wfurt @geoffkizer ptal.