This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Conversation
| /// </summary> | ||
| /// <param name="featureName">The directory name for the feature</param> | ||
| /// <returns>A path within the user's home directory for persisting data for the feature</returns> | ||
| internal static string GetUserFeatureDirectory(string featureName) |
Member
There was a problem hiding this comment.
Doesn't System.Security.Cryptography.X509Certificates in CoreFX use this?
Author
There was a problem hiding this comment.
Could we move the corefx part to corefx as partial class of this type to make it more obvious?
Member
There was a problem hiding this comment.
corefx uses everything in this file. It was originally written in corefx and only moved to the shared folder when some of the support in corefx that was using it moved to corelib.
jkotas
approved these changes
Oct 23, 2019
stephentoub
approved these changes
Oct 23, 2019
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Oct 23, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Oct 23, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Oct 23, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
to stephentoub/corefx
that referenced
this pull request
Oct 23, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Oct 23, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
vargaz
pushed a commit
to mono/mono
that referenced
this pull request
Oct 24, 2019
* Apply SuppressGCAttribute to some SPCL functions. (dotnet/coreclr#27369) Apply SuppressGCAttribute to some SPCL functions. Only insert GC_POLL in first morph call. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> * Remove unused methods (dotnet/coreclr#27370) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> * Move Matrix3x2/4x4, Plan, and Quaternion to the shared CoreLib partition (#42021) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> * Remove Socket.InnerSafeCloseSocket (dotnet/corefx#41888) * Remove Socket.InnerSafeCloseSocket * Move IsInvalid checks in SetHandle function * PR feedback * Remove unnecessary 'SocketPal.' * Remove SafeSocketHandle.SetHandle Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Oct 24, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Oct 24, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.