This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add EnumeratorCancellationAttribute#37064
Merged
stephentoub merged 3 commits intodotnet:masterfrom Apr 20, 2019
Merged
Conversation
stephentoub
commented
Apr 20, 2019
jcouv
reviewed
Apr 20, 2019
| public abstract partial class ChannelReader<T> | ||
| { | ||
| public virtual System.Collections.Generic.IAsyncEnumerable<T> ReadAllAsync() { throw null; } | ||
| public virtual System.Collections.Generic.IAsyncEnumerable<T> ReadAllAsync([System.Runtime.CompilerServices.EnumeratorCancellationAttribute] System.Threading.CancellationToken cancellationToken = default) { throw null; } |
Member
There was a problem hiding this comment.
nit: It seems ok to put the attribute there, as a form of documentation, but it won't do anything. The attribute must be placed on implementations to generate the desired GetAsyncEnumerator code.
terrajobst
approved these changes
Apr 20, 2019
tarekgh
approved these changes
Apr 20, 2019
|
Excellent. The corresponding PR in .NET Standard is also available now. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Update ChannelReader.ReadAllAsync for EnumeratorCancellationAttribute * Add EnumeratorCancellationAttribute * Address PR feedback Commit migrated from dotnet/corefx@13cd961
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the new EnumeratorCancellationAttribute to System.Runtime. Eventually we may want to push the implementation down to corelib if/when it's needed for APIs in corelib, but for now we can just have it in corefx.
Also updates the new ChannelReader.ReadAllAsync method to use the attribute and revised pattern.
I'd like to get this merged asap.
cc: @terrajobst, @jcouv, @tarekgh, @bartonjs
Fixes https://github.com/dotnet/corefx/issues/37012