This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Delete dead code after Hashtable.cs move#29432
Merged
stephentoub merged 1 commit intodotnet:masterfrom May 1, 2018
Merged
Conversation
stephentoub
reviewed
May 1, 2018
| </data> | ||
| <data name="ArgumentOutOfRange_FileLengthTooBig" xml:space="preserve"> | ||
| <value>Specified file length was too large for the file system.</value> | ||
| </data> |
Member
There was a problem hiding this comment.
This one appears to still be used:
/Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/Common/src/CoreLib/Interop/Unix/Interop.IOErrors.cs(154,68): error CS0117: 'SR' does not contain a definition for 'ArgumentOutOfRange_FileLengthTooBig' [/Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.Extensions/src/System.Runtime.Extensions.csproj]
morganbr
pushed a commit
to morganbr/corefx
that referenced
this pull request
Jul 7, 2018
zacharycmontoya
pushed a commit
that referenced
this pull request
Aug 14, 2018
* Manually update the version of Microsoft.TargetingPack.Private.NETNative * Set Microsoft.TargetPack.Private.NETNative version to track live TFS version * Move Hashtable & friends to shared parition Include serialization info table for Hashtable Remove hashtable & hashprovider src link * Compile hashtable & friends only on uapaot * Fix build breaks * Remove Opcodes due to Opcodes moved to S.P.Corelib * Move Hashtable & friends to shared parition (dotnet/coreclr#17316) (#29307) * Move Hashtable & friends to shared parition * Move HashHelper serialization logic into its own file * Remove unchecked keyword in Hashtable Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> * Moving ConcurrentQueue to shared folder (dotnet/coreclr#17956) * Moving ConcurrentQueue to shared folder Fixes: #17751 Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> * Moving ConcurrentQueue to shared (dotnet/coreclr#18024) Making IProducerConsumerCollectionDebugView apis public Fixes: #17751 Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> * Modify corefx to use ConcurrentQueue from shared * Delete dead code after Hashtable.cs move (#29432) * Replace LowLevelDictionary with Dictionary (#29411) * Avoid substring allocations in WebUtility.HtmlDecode (#29402) * Avoid substring allocations in WebUtility.HtmlDecode * Update changes to HtmlDecode based on feedback - Use regular Dictionary instead of LowLevelDictionary - Use AsSpan overload instead of AsSpan() and Slice - Avoid shift by variable amount - Use helper method to generate keys to make the code easier to maintain * Assert that entity length is <= 8 in ToUInt64Key - Add assert to ToUInt64Key - Replace default with 0 * Remove CoreSetup, External, and Sni dependencies * Update the CoreFx dependency to release/2.1 so that Microsoft.NETCore.Platforms is defined correctly. Manually invoke the dependency update * Removing Fedora 26 and adding 28 as appropriate. Fix a couple README.md typos. * Remove Ubuntu 17.10 from CoreFX official runs
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@4ec2d19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.