Port type moves to UWP 6.2#30886
Conversation
Include serialization info table for Hashtable Remove hashtable & hashprovider src link
…otnet#29307) * Move Hashtable & friends to shared parition * Move HashHelper serialization logic into its own file * Remove unchecked keyword in Hashtable Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
* Moving ConcurrentQueue to shared folder Fixes: dotnet#17751 Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Making IProducerConsumerCollectionDebugView apis public Fixes: dotnet#17751 Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
* Avoid substring allocations in WebUtility.HtmlDecode * Update changes to HtmlDecode based on feedback - Use regular Dictionary instead of LowLevelDictionary - Use AsSpan overload instead of AsSpan() and Slice - Avoid shift by variable amount - Use helper method to generate keys to make the code easier to maintain * Assert that entity length is <= 8 in ToUInt64Key - Add assert to ToUInt64Key - Replace default with 0
| </Compile> | ||
| </ItemGroup> | ||
| <!-- TODO: Remove these lines when a new uapaot build is ingested into corefx. --> | ||
| <ItemGroup Condition="'$(TargetGroup)' == 'uapaot'"> |
There was a problem hiding this comment.
I think we don't need the condition here anymore. This was removed with 246b505#diff-c2575c0f880b096356277e8cc2b31462
There was a problem hiding this comment.
I think you reviewed one of the intermediate commits. That shouldn't be in the final version.
There was a problem hiding this comment.
Right. You added Jans commit that deletes these lines afterwards. Overlooked it. Thanks.
….Platforms is defined correctly. Manually invoke the dependency update
|
I appended my dependency updates from #31663 to the tip of this PR, and the resulting CI should be green. |
|
@dotnet-bot test NETFX x86 Release Build |
|
@dotnet-bot test Linux x64 Release Build |
|
@MattGal the PR test run shows Fedora.26.Amd64.Open-x64 on fire. Is this new? |
|
@zamont just sent mail again, please see me if you need help. I notified folks that this OS was end-of-life and that this would begin happening yesterday last Thursday. |
|
@MichalStrehovsky when can we move forward with this set of changes? I believe Morgan is also out this week |
Since these changes are required to unblock the ingestion at the .NET Native side, I would say ASAP? What help do you need from me on this? |
|
Ok. I will go ahead and merge this then. |
|
@zamont, the reason I hadn't merged this is that we didn't have a build of CoreCLR that matched it. If you have that now, merging was fine. Thanks for taking care of it. |
|
Yup, we've got our uwp6.2 builds up and running so we were able to produce a new CoreCLR build with matching CoreLib. Awesome :) |
The .NET Native CoreLib already has the types that moved in master (Hashtable and ConcurrentQueue), so we need CoreFX to include the matching changes. Also includes porting a couple other changes that the ports depended on.
Depends on dotnet/coreclr#18818 so the uap flavor builds too.