This repository was archived by the owner on Jan 23, 2023. It is now read-only.
added implicit cast operator from ArraySegment to Spans#7297
Merged
jkotas merged 2 commits intodotnet:SpanOfTfrom Sep 21, 2016
Merged
added implicit cast operator from ArraySegment to Spans#7297jkotas merged 2 commits intodotnet:SpanOfTfrom
jkotas merged 2 commits intodotnet:SpanOfTfrom
Conversation
Member
These contracts are debug-only. There should be no harm in using the existing assessors. |
…ntracts for it's properties are debug-only
Member
Author
@jkotas thanks for explanation. I updated the code |
Member
|
👍 |
jkotas
pushed a commit
to jkotas/coreclr
that referenced
this pull request
Oct 29, 2016
jkotas
pushed a commit
to jkotas/coreclr
that referenced
this pull request
Oct 29, 2016
jkotas
pushed a commit
to jkotas/coreclr
that referenced
this pull request
Oct 29, 2016
jkotas
pushed a commit
to jkotas/coreclr
that referenced
this pull request
Oct 29, 2016
jkotas
pushed a commit
to jkotas/coreclr
that referenced
this pull request
Oct 31, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion, corefxlab PR
I did not use public getter's of ArraySegment (Array, Offset, Count) because they contain code contracts that would be duplicated by the constructors of Spans. Moreover the ctor of Span is more demanding because it additionaly checks for covariance. That's why I decided to avoid double checks and made the fields of ArraySegment internal.
@jkotas @KrzysztofCwalina