This repository was archived by the owner on Aug 2, 2023. It is now read-only.
added implicit ArraySegment->Spans and explicit ArraySegment<byte>->Utf8String#833
Merged
KrzysztofCwalina merged 2 commits intodotnet:masterfrom Sep 21, 2016
Merged
Conversation
…ArraySegment<byte> to Utf8String, fixes dotnet#832
| { | ||
| } | ||
|
|
||
| public static explicit operator Utf8String(ArraySegment<byte> arraySegment) |
Member
There was a problem hiding this comment.
I have been trying to call such parameters "utf8Bytes" to communicate to callers that they need to ensure that the bytes are actually valid UTF8.
Member
Author
There was a problem hiding this comment.
@KrzysztofCwalina good point. I have updated the code
…the bytes should be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@KrzysztofCwalina this should fix #832