Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix issue 4367 where file description of native tools is wrong#4598

Merged
joperezr merged 2 commits intodotnet:masterfrom
joperezr:Fix4367
Apr 27, 2016
Merged

Fix issue 4367 where file description of native tools is wrong#4598
joperezr merged 2 commits intodotnet:masterfrom
joperezr:Fix4367

Conversation

@joperezr
Copy link
Member

@joperezr joperezr commented Apr 26, 2016

fixes: #4367 + changing the verbosity of the generation of native assets.

CC: @AndyAyersMS @weshaggard

@AndyAyersMS
Copy link
Member

Thanks, LGTM.

@joperezr
Copy link
Member Author

@mellinoe Looks like the reason why CI broke with this new version of buildtools is that when this code was added dotnet/buildtools#655 it brought to light some issues that coreclr repo had but where very luckily working before. For example, non of the tests assemblies where being signed even though the IsTestProject variable wasn't defined, and this was because this line was being overriden later in the import tree by the VS MSBuild targets. When you added IL.targets, this line imports the VS targets first, so now the test projects are failing when they try to be signed.

I guess a possible fix would be to disable the signing by setting <SkipSigning>true</SkipSigning> but even if that works the new imported IL.targets will conflict with the coreclr's IL.targets so we that might add extra errors/warnings.

@joperezr joperezr merged commit 59fcb93 into dotnet:master Apr 27, 2016
@joperezr joperezr deleted the Fix4367 branch April 27, 2016 15:59
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…t/coreclr#4598)

Fix issue 4367 where file description of native tools is wrong


Commit migrated from dotnet/coreclr@59fcb93
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Corerun (or something) munges the task description on windows

5 participants