This repository was archived by the owner on Jan 11, 2024. It is now read-only.
Hook .ilproj files into the build#655
Merged
mellinoe merged 1 commit intodotnet:masterfrom Apr 21, 2016
Merged
Conversation
* Import IL.targets if the project extension is ".ilproj" * Use hyphen syntax for ilasm flags, the forward-slash syntax does not work on non-Windows ilasm.
Member
|
LGTM |
Author
|
Thanks Wes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a few small changes to enable building "ilproj" files as a regular participant in the build. This just imports the existing targets file if the file's extension is detected as ".ilproj". This will be used to build the
System.Unsafelibrary in corefx (https://github.com/mellinoe/corefx/tree/system.unsafe).There is also a minor modification to the calling syntax for ilasm so that it will work with the x-plat version of ilasm. "Forward-slash syntax" doesn't work in the x-plat version of ilasm. Currently it seems like the nuget packages for ilasm are broken, though, so I have not been able to incorporate it into the tool runtime yet. I have done manual testing of the scenario.
work on non-Windows ilasm.
@weshaggard