This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Do not clip CPU count when CPU quota is used. (#26153)#26806
Merged
jkotas merged 1 commit intodotnet:release/3.1from Sep 23, 2019
Merged
[release/3.1] Do not clip CPU count when CPU quota is used. (#26153)#26806jkotas merged 1 commit intodotnet:release/3.1from
jkotas merged 1 commit intodotnet:release/3.1from
Conversation
|
Approved pending on code review for 3.1 |
sergiy-k
approved these changes
Sep 21, 2019
VSadov
approved these changes
Sep 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have heard from multiple customers deploying .NET Core micro-services in Kubernetes that clipping of CPU count when CPU quota is used results into a performance cliff in commonly used configuration.
We have added this clipping late during 3.0. It was controversial change and the data supporting the change were not very strong. This change reverts change. The change was reverted in master already.
Regression?
Yes (2.x -> 3.0)
Risk
Small chance that .NET Core 3.0 deployments may started depending on the broken behavior. They will need to be reconfigured.