Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Do not clip CPU count when CPU quota is used.#26153

Merged
VSadov merged 1 commit intodotnet:masterfrom
VSadov:cpuCount
Aug 23, 2019
Merged

Do not clip CPU count when CPU quota is used.#26153
VSadov merged 1 commit intodotnet:masterfrom
VSadov:cpuCount

Conversation

@VSadov
Copy link
Member

@VSadov VSadov commented Aug 13, 2019

Fixes:#26053

@VSadov VSadov changed the title [WIP] Do not clip CPU count when CPU quota is used. Do not clip CPU count when CPU quota is used. Aug 22, 2019
@VSadov VSadov marked this pull request as ready for review August 22, 2019 22:45
@VSadov VSadov requested review from janvorli, jkotas and sergiy-k August 22, 2019 22:45
@VSadov
Copy link
Member Author

VSadov commented Aug 22, 2019

This is basically the "fix". It is just undoing the clipping.

It does not look like we have any tests for this. Evidently nothing failed.
I wonder if it is easily testable within our infrastructure...

@VSadov VSadov merged commit db8fc1b into dotnet:master Aug 23, 2019
@VSadov
Copy link
Member Author

VSadov commented Aug 24, 2019

I am not sure this is bad enough for 3.0 at this point, but may be worth taking to 3.1

Should we port the fix or wait for more feedback?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider not restricting level of parallelism in a container when user did not ask for it.

3 participants