Skip to content

Sync shared code from runtime#29520

Closed
github-actions[bot] wants to merge 1 commit intomainfrom
github-action/sync-runtime-1611304851
Closed

Sync shared code from runtime#29520
github-actions[bot] wants to merge 1 commit intomainfrom
github-action/sync-runtime-1611304851

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 22, 2021

This PR was automatically generated to sync shared code changes from runtime. Fixes #18943

@github-actions github-actions bot requested a review from a team January 22, 2021 08:40
@jkotalik
Copy link
Contributor

jkotalik commented Jan 22, 2021

Actually, maybe we should do the reverse and change this in runtime? Though this change shouldn't affect anything...

@Tratcher
Copy link
Member

Tratcher commented Jan 22, 2021

@dougbu which way do you want it?

@dougbu
Copy link
Contributor

dougbu commented Jan 22, 2021

The name of this repo is dotnet/aspnetcore 〰️ all lower case. We should avoid adding more mixed-case instances. Can we do that❔ (Sorry I missed this when doing dotnet/runtime#47306)

But, I'm not sure why dotnet/runtime#47306 led to this change; the case was mixed prior to that PR. Were the runtime and aspnetcore files not completely aligned before the GitHub action was set up❔

@Tratcher
Copy link
Member

Tratcher commented Jan 22, 2021 •
edited
Loading

You changed the case in aspnetcore but not in runtime. Go ahead an fix it in runtime then and we can close this PR.
e17569e#diff-01fc1175fbeef90a25b800c9820b9aef0bae58fbc6a92fe2f4c870788af4e7aaR27

@dougbu
Copy link
Contributor

dougbu commented Jan 22, 2021

Go ahead an fix it in runtime then and we can close this PR.

Will do @Tratcher

@Tratcher Tratcher closed this Jan 22, 2021
@Tratcher Tratcher deleted the github-action/sync-runtime-1611304851 branch January 22, 2021 17:59
@dougbu dougbu mentioned this pull request Jan 22, 2021
Merged
dougbu added a commit to dotnet/runtime that referenced this pull request Jan 22, 2021
@dougbu
Clean up aspnetcore casing in ref to that repo (#47347)
e63969d 
- address difference I introduced in dotnet/aspnetcore#29511 and more
    - conflict detected in dotnet/aspnetcore#29520
- also s|aspnet/aspnetcore|dotnet/aspnetcore|
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jkotalik jkotalik jkotalik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dougbu dougbu

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The runtime<->aspnetcore shared src is out of sync

4 participants

@jkotalik @Tratcher @dougbu @amcasey