Merged
Conversation
- part of #29475 - primarily involves updating links to this repo nit: Remove broken links to old Travis environments (that happen to mention 'master')
BrennanConroy
approved these changes
Jan 22, 2021
dougbu
commented
Jan 22, 2021
| } | ||
|
|
||
| compileJava.dependsOn generateVersionClass No newline at end of file | ||
| compileJava.dependsOn generateVersionClass |
Contributor
Author
There was a problem hiding this comment.
Didn't think I set VS Code to add trailing newlines everywhere. Will this cause problems @BrennanConroy❔
Member
There was a problem hiding this comment.
Hope not, we'll see if the CI fails :D
wtgodbe
approved these changes
Jan 22, 2021
Contributor
Author
|
Note: This will go in after I rename the branch. In a sense, it'll test out the auto-magic PR handling😁 |
Contributor
|
FYI @sebastienros |
pranavkm
approved these changes
Jan 22, 2021
Tratcher
approved these changes
Jan 22, 2021
|
|
||
| ## Building dotnet/AspNetCore code: | ||
| - https://github.com/dotnet/AspNetCore/blob/master/docs/BuildFromSource.md | ||
| - https://github.com/dotnet/aspnetcore/blob/main/docs/BuildFromSource.md |
Member
There was a problem hiding this comment.
This file must be updated in runtime as well or the bot will overwrite this change.
Contributor
Author
There was a problem hiding this comment.
Thanks @Tratcher❕ See dotnet/runtime#47306
|
Hello @dougbu! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
dougbu
added a commit
to dotnet/runtime
that referenced
this pull request
Jan 22, 2021
- address difference I introduced in dotnet/aspnetcore#29511 and more - conflict detected in dotnet/aspnetcore#29520 - also s|aspnet/aspnetcore|dotnet/aspnetcore|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nit: Remove broken links to old Travis environments (that happen to mention 'master')