Update VersionTools and add IsReleaseOnlyPackageVersion #1434
Update VersionTools and add IsReleaseOnlyPackageVersion #1434epananth merged 4 commits intodotnet:masterfrom
Conversation
|
Asset Manifest Merged Manifest Link to the artifacts -> https://dev.azure.com/dnceng/internal/_build/results?buildId=846325&view=artifacts&type=publishedArtifacts |
|
Need to revert this change -> dotnet/arcade#6319 :/ |
| Commit = GetAzDevCommit(), | ||
| IsStable = IsStableBuild.ToString(), | ||
| PublishingVersion = manifestBuildData.PublishingVersion.ToString() | ||
| PublishingVersion = (PublishingInfraVersion)manifestBuildData.PublishingVersion, |
There was a problem hiding this comment.
Can you explain why this cast is now required?
There was a problem hiding this comment.
For the older MicrosoftDotNetVersionToolsVersion PublishingVersion was int, the newer MicrosoftDotNetVersionToolsVersion
PublishingVersion is an enum.
There was a problem hiding this comment.
Should we be concerned that someone passes an invalid number here? the direct cast won't fail if provided an invalid int.
There was a problem hiding this comment.
That part of validation is done in arcade, since we are just passing the value I think we should be good.
riarenas
left a comment
There was a problem hiding this comment.
LGTm, just the question about safeguarding against invalid enum values.
For the IsReleaseOnlyPackageVersion to show in the merged manifest
First part was Arcade master change -> dotnet/arcade#6340
Release 3.x -> dotnet/arcade#6319
For the merged manifest, we need to update the MicrosoftDotNetVersionToolsVersion to the latest version and add the IsReleaseOnlyPackageVersion attribute in the manifest.
Test Build from arcade-services to generated updated Maestro task -> https://dev.azure.com/dnceng/internal/_build/results?buildId=846200&view=results
Test build from arcade with the updated maestro task , arcade sdk and feeds task -> https://dev.azure.com/dnceng/internal/_build/results?buildId=846325&view=results