Added extra attribute to manifest to arcade 3.x #6340
Merged
epananth merged 3 commits intodotnet:release/3.xfrom Oct 7, 2020
epananth:manifest-update-3x
Merged
Added extra attribute to manifest to arcade 3.x #6340epananth merged 3 commits intodotnet:release/3.xfrom epananth:manifest-update-3x
epananth merged 3 commits intodotnet:release/3.xfrom
epananth:manifest-update-3x
Conversation
Member
|
Everything's on the floor from the outages, but wasn't there also a test change needed with this? |
Member
Author
|
with the outage, my test is not going to pass :( So I created a PR anyway. I will run a build and whenever it passes, I will merge this.. |
Member
|
For release/3.x, I think the PR text should fill out https://github.com/dotnet/arcade/blob/master/Documentation/Policy/AskModeTellModeTemplate.md too. |
2 tasks
epananth
added a commit
that referenced
this pull request
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same change as #6319, but the target branch is arcade 3.x
Customer Impact
Customer impact if this change is not made.
Regression
Testing here ->https://dnceng.visualstudio.com/internal/_build/results?buildId=843160&view=results ( cos of the outage this might not run)
Risk
How risky is this change? Not risky, just adding another attribute to the manifest
Workarounds
Are there available workarounds for the bug? No, have to make this change so that arcade-services get the attribute.