Add a new element to the manifest UsesReleaseOnlyPackageVersion#6319
Merged
epananth merged 18 commits intodotnet:masterfrom Oct 6, 2020
epananth:add-check
Merged
Add a new element to the manifest UsesReleaseOnlyPackageVersion#6319epananth merged 18 commits intodotnet:masterfrom epananth:add-check
epananth merged 18 commits intodotnet:masterfrom
epananth:add-check
Conversation
mmitche
reviewed
Oct 5, 2020
| <IsStableBuild>false</IsStableBuild> | ||
| <IsStableBuild Condition="'$(DotNetFinalVersionKind)' == 'release'">true</IsStableBuild> | ||
|
|
||
| <UsesReleaseOnlyPackageVersion>false</UsesReleaseOnlyPackageVersion> |
Member
There was a problem hiding this comment.
Can you add a comment here indicating what this property indicates and why we are passing it to the manifest creation?
mmitche
approved these changes
Oct 5, 2020
MattGal
approved these changes
Oct 5, 2020
| /// <summary> | ||
| /// Is the manifest for Release only package version? | ||
| /// </summary> | ||
| public bool UsesReleaseOnlyPackageVersion { get; set; } |
Member
There was a problem hiding this comment.
Nit: Can't point to any rules saying one way or the other but this variable seems like either IsReleaseOnlyPackageVersion (if this variable tells us the package versions are already like that, as IsStableBuild does above) or `UseReleaseOnlyPackageVersion' (if you set the value when it's about to generate a version). I think there's a fair bit of precedent in the framework.
Member
Author
|
Yay! test caught a bug! :) |
This was referenced Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part one adding element to the manifest ->Issue (#6276)
test build -> https://dnceng.visualstudio.com/internal/_build/results?buildId=840108&view=results
For the merged manifest to have the additional attribute (in Maestro task) this has to be merged.