Move common parts of sdl templates to additional templates#8247
Merged
michellemcdaniel merged 2 commits intodotnet:mainfrom Dec 7, 2021
Merged
Move common parts of sdl templates to additional templates#8247michellemcdaniel merged 2 commits intodotnet:mainfrom
michellemcdaniel merged 2 commits intodotnet:mainfrom
Conversation
SDL Validation is done in both the repos and the staging/validaiton pipelines. Today, we have a large amount of the sdl job template duplicated for the staging/validation pipelines because we need to use different sources/we don't need all the artifact downloading (and if we did, we would want to get the artifacts from a different place). This duplication leads to issues like dotnet#8243 (among others), where versions changed in arcade, but they weren't properly migrated to dotnet-release, and the validation pipeline started failing. This change moves the duplicated steps to a steps template, and the duplicated variables to a variables template, so we can more easily share between these repos/pipelines.
riarenas
reviewed
Dec 7, 2021
riarenas
reviewed
Dec 7, 2021
jonfortescue
reviewed
Dec 7, 2021
| @@ -0,0 +1,68 @@ | |||
| parameters: | |||
| overrideGuadianVersion: '' | |||
Contributor
There was a problem hiding this comment.
Suggested change
| overrideGuadianVersion: '' | |
| overrideGuardianVersion: '' |
riarenas
approved these changes
Dec 7, 2021
Contributor
riarenas
left a comment
There was a problem hiding this comment.
LGTM, Maybe run an internal arcade build just to check that non-release repo pipelines are fine?
Contributor
Author
Running now. Good idea. https://dev.azure.com/dnceng/internal/_build/results?buildId=1501387&view=results |
Contributor
Author
|
Test succeeded |
1 task
garath
pushed a commit
to garath/dotnet-arcade
that referenced
this pull request
Mar 1, 2022
* Move common parts of sdl templates to additional templates SDL Validation is done in both the repos and the staging/validaiton pipelines. Today, we have a large amount of the sdl job template duplicated for the staging/validation pipelines because we need to use different sources/we don't need all the artifact downloading (and if we did, we would want to get the artifacts from a different place). This duplication leads to issues like dotnet#8243 (among others), where versions changed in arcade, but they weren't properly migrated to dotnet-release, and the validation pipeline started failing. This change moves the duplicated steps to a steps template, and the duplicated variables to a variables template, so we can more easily share between these repos/pipelines. * Fix typo
garath
added a commit
that referenced
this pull request
Mar 8, 2022
Resolve remaining CodeQL errors. This also brings in #8247 to get the same template arrangement as the main branch. Co-authored-by: Michelle McDaniel <michelm@microsoft.com> Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDL Validation is done in both the repos and the staging/validation pipelines. Today, we have a large amount of the sdl job template duplicated for the staging/validation pipelines because we need to use different sources/we don't need all the artifact downloading (and if we did, we would want to get the artifacts from a different place). This duplication leads to issues like #8243 (among others), where versions changed in arcade, but they weren't properly migrated to dotnet-release, and the validation pipeline started failing.
This change moves the duplicated steps to a steps template, and the duplicated variables to a variables template, so we can more easily share between these repos/pipelines.
To double check:
This was tested in https://dev.azure.com/dnceng/internal/_build/results?buildId=1499177&view=results.