Make CodeQL Clean (release/6.0)#8536
Merged
garath merged 10 commits intodotnet:release/6.0from Mar 8, 2022
Merged
Conversation
* Move common parts of sdl templates to additional templates SDL Validation is done in both the repos and the staging/validaiton pipelines. Today, we have a large amount of the sdl job template duplicated for the staging/validation pipelines because we need to use different sources/we don't need all the artifact downloading (and if we did, we would want to get the artifacts from a different place). This duplication leads to issues like dotnet#8243 (among others), where versions changed in arcade, but they weren't properly migrated to dotnet-release, and the validation pipeline started failing. This change moves the duplicated steps to a steps template, and the duplicated variables to a variables template, so we can more easily share between these repos/pipelines. * Fix typo
riarenas
previously approved these changes
Mar 7, 2022
mmitche
reviewed
Mar 7, 2022
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/BuildModelFactoryTests.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Mar 7, 2022
mmitche
reviewed
Mar 7, 2022
src/Microsoft.DotNet.VersionTools/tests/BuildManifest/ManifestModelTests.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Mar 7, 2022
src/SignCheck/Microsoft.SignCheck/Verification/ArchiveVerifier.cs
Outdated
Show resolved
Hide resolved
mmitche
previously approved these changes
Mar 7, 2022
Member
mmitche
left a comment
There was a problem hiding this comment.
LGTM, just minor comments and questions
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
mmitche
reviewed
Mar 7, 2022
mmitche
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve remaining CodeQL errors.
This also brings in #8247 to get the same template arrangement as the main branch.
This build was run against this branch and confirms no errors from the scanner.
Part of dotnet/core-eng#15545