Skip to content

Make CodeQL Clean (release/6.0)#8536

Merged
garath merged 10 commits intodotnet:release/6.0from
garath:mistucke/codeqlclean-6.0
Mar 8, 2022
Merged

Make CodeQL Clean (release/6.0)#8536
garath merged 10 commits intodotnet:release/6.0from
garath:mistucke/codeqlclean-6.0

Conversation

@garath
Copy link
Member

@garath garath commented Mar 2, 2022

Resolve remaining CodeQL errors.

This also brings in #8247 to get the same template arrangement as the main branch.

This build was run against this branch and confirms no errors from the scanner.

Part of dotnet/core-eng#15545

garath and others added 7 commits March 1, 2022 13:14
* Move common parts of sdl templates to additional templates

SDL Validation is done in both the repos and the staging/validaiton pipelines. Today, we have a large amount of the sdl job template duplicated for the staging/validation pipelines because we need to use different sources/we don't need all the artifact downloading (and if we did, we would want to get the artifacts from a different place). This duplication leads to issues like dotnet#8243 (among others), where versions changed in arcade, but they weren't properly migrated to dotnet-release, and the validation pipeline started failing.

This change moves the duplicated steps to a steps template, and the duplicated variables to a variables template, so we can more easily share between these repos/pipelines.

* Fix typo
@garath garath requested review from mmitche and riarenas March 2, 2022 20:01
@garath garath self-assigned this Mar 2, 2022
riarenas
riarenas previously approved these changes Mar 7, 2022
mmitche
mmitche previously approved these changes Mar 7, 2022
Copy link
Member

@mmitche mmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor comments and questions

Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
@garath garath dismissed stale reviews from mmitche and riarenas via e1f2d05 March 7, 2022 20:34
@garath garath requested review from mmitche and riarenas March 7, 2022 21:19
@garath garath enabled auto-merge (squash) March 7, 2022 21:33
@garath garath merged commit 41a914d into dotnet:release/6.0 Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants