Skip to content

Prefer nuget standardized properties#7212

Merged
ViktorHofer merged 1 commit intomainfrom
ViktorHofer-patch-1
Apr 9, 2021
Merged

Prefer nuget standardized properties#7212
ViktorHofer merged 1 commit intomainfrom
ViktorHofer-patch-1

Conversation

@ViktorHofer
Copy link
Member

ReleaseNotes and Tags are the only properties that aren't deprecated which have a different property name on the NuGet side than in Microsoft.DotNet.Build.Tasks.Packaging. The ReleaseNotes rename to PackageReleaseNotes needs an update in the dotnet/runtime repo.

ReleaseNotes and Tags are the only properties that aren't deprecated which have a different property name on the NuGet side than in Microsoft.DotNet.Build.Tasks.Packaging. The ReleaseNotes rename to PackageReleaseNotes needs an update in the dotnet/runtime repo.
@ViktorHofer ViktorHofer requested a review from ericstj April 9, 2021 17:31
@ViktorHofer ViktorHofer self-assigned this Apr 9, 2021
ViktorHofer added a commit to dotnet/runtime that referenced this pull request Apr 9, 2021
Requires dotnet/arcade#7212. Helps with the pkgproj to csproj conversion.
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ViktorHofer ViktorHofer merged commit 28d9452 into main Apr 9, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch April 9, 2021 22:29
ViktorHofer added a commit that referenced this pull request Apr 9, 2021
ViktorHofer added a commit to dotnet/runtime that referenced this pull request Apr 12, 2021
* Use nuget standardized properties

Requires dotnet/arcade#7212. Helps with the pkgproj to csproj conversion.
akoeplinger pushed a commit to akoeplinger/arcade that referenced this pull request Apr 12, 2021
ReleaseNotes and Tags are the only properties that aren't deprecated which have a different property name on the NuGet side than in Microsoft.DotNet.Build.Tasks.Packaging. The ReleaseNotes rename to PackageReleaseNotes needs an update in the dotnet/runtime repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants