Skip to content

Use nuget standardized properties#51014

Merged
ViktorHofer merged 2 commits intomainfrom
ViktorHofer-patch-1
Apr 12, 2021
Merged

Use nuget standardized properties#51014
ViktorHofer merged 2 commits intomainfrom
ViktorHofer-patch-1

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 9, 2021

Requires dotnet/arcade#7212. Helps with the pkgproj to csproj conversion.

@ViktorHofer
Use nuget standardized properties
4905d0f 
Requires dotnet/arcade#7212. Helps with the pkgproj to csproj conversion.
@ViktorHofer ViktorHofer requested review from Anipik and ericstj April 9, 2021 17:32
@ViktorHofer ViktorHofer self-assigned this Apr 9, 2021
@ghost
Copy link

ghost commented Apr 9, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Requires dotnet/arcade#7212. Helps with the pkgproj to csproj conversion.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries
Milestone: -

@ericstj
Copy link
Member

ericstj commented Apr 9, 2021

Make sure to diff NuSpecs after this change to ensure we have everything we need.

@ViktorHofer ViktorHofer merged commit 2ada920 into main Apr 12, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch April 12, 2021 16:38
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 13, 2021 •
edited
Loading

Diffed the nuspec properties and some of recently discussed properties are in the nuspec and are correct:

  • projectUrl
  • releaseNotes

Checked XmlSerializer.Generator package as well as it overwrites some nuget properties.

  <metadata minClientVersion="2.12">
    <id>Microsoft.XmlSerializer.Generator</id>
    <version>6.0.0-preview.4.21213.3</version>
    <title>Microsoft.XmlSerializer.Generator</title>
    <authors>Microsoft</authors>
    <owners>microsoft,dotnetframework</owners>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <license type="expression">MIT</license>
    <icon>Icon.png</icon>
    <projectUrl>https://go.microsoft.com/fwlink/?linkid=858594</projectUrl>
    <iconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</iconUrl>
    <description>Creates an Xml serialization assembly for types contained in an assembly in order to improve the startup performance of Xml serialization when serializing or de-serializing objects of those types using XmlSerializer.</description>
    <releaseNotes>https://go.microsoft.com/fwlink/?LinkID=863421</releaseNotes>
    <copyright>© Microsoft Corporation. All rights reserved.</copyright>
    <serviceable>true</serviceable>
    <repository type="git" url="https://github.com/dotnet/runtime" commit="5d0817a2136b84580a78fea5bfbe9910098bed2b" />
    <dependencies>
      <group targetFramework=".NETStandard2.0" />
    </dependencies>
  </metadata>

@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@safern safern safern approved these changes

@ericstj ericstj Awaiting requested review from ericstj

@Anipik Anipik Awaiting requested review from Anipik

Assignees

@ViktorHofer ViktorHofer

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ViktorHofer @ericstj @safern @karelz