Relax PublishArtifactInManifest safety check#4682
Merged
JohnTortugo merged 2 commits intomasterfrom Jan 26, 2020
Merged
Conversation
riarenas
reviewed
Jan 24, 2020
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifest.cs
Outdated
Show resolved
Hide resolved
Contributor
|
How are you validating this? |
Contributor
|
LGTM and will approve when we have some test builds that show this is not regressing anything, and actually lets the versions that were previously failing succeed. |
brettfo
reviewed
Jan 24, 2020
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifest.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Tested the patched SDK + Tasks.Feed on these builds: |
brettfo
approved these changes
Jan 26, 2020
2 tasks
riarenas
pushed a commit
to riarenas/arcade
that referenced
this pull request
Jun 25, 2020
* Relax PublishArtifactInManifest safety check * Remove validation of publishing stable assets to non-isolated feed.
riarenas
added a commit
that referenced
this pull request
Jun 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4680