Skip to content

Relax PublishArtifactInManifest safety check (#4682)#5709

Merged
riarenas merged 1 commit intodotnet:release/3.xfrom
riarenas:riarenas/relax-stable-publishing-3.x
Jun 25, 2020
Merged

Relax PublishArtifactInManifest safety check (#4682)#5709
riarenas merged 1 commit intodotnet:release/3.xfrom
riarenas:riarenas/relax-stable-publishing-3.x

Conversation

@riarenas
Copy link
Contributor

@riarenas riarenas commented Jun 25, 2020

This ports 0fcbdf1 to the release/3.x branch. It removes the safety checks around the publishing of stable assets to non-stable feeds.

The justification and servicing template are found in #5487

@JohnTortugo @riarenas
Relax PublishArtifactInManifest safety check (dotnet#4682)
be1a0c3 
* Relax PublishArtifactInManifest safety check

* Remove validation of publishing stable assets to non-isolated feed.
@riarenas riarenas added the auto-merge Automatically merge PR once CI passes. label Jun 25, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

Hello @riarenas!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jun 25, 2020

Apologies, while this PR appears ready to be merged, it looks like release/3.x is a protected branch and I have not been granted permission to perform the merge.

@riarenas riarenas merged commit e9a3fdd into dotnet:release/3.x Jun 25, 2020
@riarenas riarenas deleted the riarenas/relax-stable-publishing-3.x branch June 25, 2020 19:17
@brettfo
Copy link
Member

brettfo commented Jul 17, 2020 •
edited
Loading

dotnet/interactive builds are still failing with Package 'Microsoft.dotnet-interactive' has stable version '1.0.136701' but is targeted at a non-isolated feed '...'. (build) That repo is currently using Arcade version 1.0.0-beta.20365.6 which appears to be the latest from the release/3.x branch. The targeted feed is .NET Core Tooling Dev.

Should we be publishing to a different channel? I've temporarily removed that channel and re-ran the failed job to unblock our builds.

@riarenas
Copy link
Contributor Author

riarenas commented Jul 17, 2020

hmm, I wonder if the release/3.x branch requires a manual update to the task version. Checking

@riarenas
Copy link
Contributor Author

riarenas commented Jul 17, 2020

yeah, that's the reason. I'll put out a PR to update the task version shortly

This was referenced Jul 17, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmitche mmitche mmitche approved these changes

@markwilkie markwilkie Awaiting requested review from markwilkie

+1 more reviewer

@JohnTortugo JohnTortugo JohnTortugo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-merge Automatically merge PR once CI passes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@riarenas @brettfo @JohnTortugo @mmitche